You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is there a reason for the change in the name style between these two classes? Could we make a PR to change the class name, and provide a using statement to allow existing code to continue to compile?
If I find the time I could make the refactoring. But I would like some feedback concerning whether there was some rationale behind the current naming...
Thank you,
Michael Uman
Sr Software/Firmware Engineer
UmanSoft.ddns.net
The text was updated successfully, but these errors were encountered:
Hi @muman613, the most important rationale here is readability. When I wrote it, I thought GPIOOutput is not very readable, hence I used the underscore. Arguably, this is inconsistent with GPIOInput. I think changing GPIOInput to GPIO_Input would make it more consistent and we would accept the pull request, in particular if it is backward-compatible using a using statement.
Hello,
Is there a reason for the change in the name style between these two classes? Could we make a PR to change the class name, and provide a
using
statement to allow existing code to continue to compile?If I find the time I could make the refactoring. But I would like some feedback concerning whether there was some rationale behind the current naming...
Thank you,
Michael Uman
Sr Software/Firmware Engineer
UmanSoft.ddns.net
The text was updated successfully, but these errors were encountered: