Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why the function name style change from GPIOInput() vs GPIO_Output() #22

Open
muman613 opened this issue Jun 2, 2023 · 1 comment
Open

Comments

@muman613
Copy link

muman613 commented Jun 2, 2023

Hello,

Is there a reason for the change in the name style between these two classes? Could we make a PR to change the class name, and provide a using statement to allow existing code to continue to compile?

If I find the time I could make the refactoring. But I would like some feedback concerning whether there was some rationale behind the current naming...

Thank you,
Michael Uman
Sr Software/Firmware Engineer
UmanSoft.ddns.net

@0xjakob
Copy link
Contributor

0xjakob commented Jun 6, 2023

Hi @muman613, the most important rationale here is readability. When I wrote it, I thought GPIOOutput is not very readable, hence I used the underscore. Arguably, this is inconsistent with GPIOInput. I think changing GPIOInput to GPIO_Input would make it more consistent and we would accept the pull request, in particular if it is backward-compatible using a using statement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants