Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/spi nand flash mt29f1 (IEC-225) #432

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Feat/spi nand flash mt29f1 (IEC-225) #432

merged 1 commit into from
Nov 1, 2024

Conversation

Teesmo
Copy link
Contributor

@Teesmo Teesmo commented Oct 16, 2024 •
edited
Loading

Checklist

  • Component contains License
  • Component contains README.md
  • Component contains idf_component.yml file with url field defined
  • Component was added to upload job
  • Component was added to build job
  • Optional: Component contains unit tests
  • CI passing

Change description

Added support for MT29F1G01ABAFDSF-AAT:F chip

@CLAassistant
Copy link

CLAassistant commented Oct 16, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot changed the title Feat/spi nand flash mt29f1 Feat/spi nand flash mt29f1 (IEC-225) Oct 16, 2024
@Teesmo Teesmo marked this pull request as draft October 16, 2024 14:38
@Teesmo Teesmo marked this pull request as ready for review October 16, 2024 14:39
@Teesmo
Copy link
Contributor Author

Teesmo commented Oct 30, 2024

@igrr how far are we with this pull request?

@igrr
Copy link
Member

igrr commented Oct 31, 2024

@Teesmo Could you check the CLA (#432 (comment))? It seems you made a commit with a different email (ending with @gmail.co) than the one added to your Github profile, so CLA Assistant doesn't recognize your sign-off.

Also, there have been some changes to spi_nand_flash.c in the meantime, could you please rebase the PR upon the latest master branch?

(If you have trouble doing this, just reply that you agree with the CLA and I can take care of rebasing and merging.)

@Teesmo Teesmo mentioned this pull request Oct 31, 2024
Closed
@Teesmo
Copy link
Contributor Author

Teesmo commented Oct 31, 2024

I agree with the CLA. I've edited the email. I hope it checks off this time

@igrr igrr force-pushed the feat/spi_nand_flash_mt29f1 branch from b6905d3 to 16bdb50 Compare November 1, 2024 13:05
@igrr igrr enabled auto-merge November 1, 2024 13:06
@igrr igrr merged commit a90ee7b into espressif:master Nov 1, 2024
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igrr igrr igrr approved these changes

Assignees
No one assigned
Labels
Component: spi_nand_flash Resolution: Done Status: Done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Teesmo @CLAassistant @igrr @espressif-bot