feat(pre_encrypted_ota): Added HTTPS server in pytest #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @mahavirj, tested this server locally, with simple download as well as partial download. Both works fine. Used the same ca_cert.pem and ca_key.pem which is used esp_https_server. |
hrushikesh430
force-pushed
the
feat/add_local_server_in_esp_encrypted_ota_pytest
branch
from
4706b8d to
8428dcc
Compare
|
@mahavirj PTAL |
hrushikesh430
force-pushed
the
feat/add_local_server_in_esp_encrypted_ota_pytest
branch
from
8428dcc to
a3d119e
Compare
|
@mahavirj Removed the certs directory from the tests dir, instead used server_cert dir for certs. And fixed some cosmetic changes in test_local_server_ota.c |
hrushikesh430
force-pushed
the
feat/add_local_server_in_esp_encrypted_ota_pytest
branch
from
a3d119e to
3112760
Compare
|
@mahavirj PTAL, updated the pytest and README.md file. In README.md mentioned about creating server_cert directory and certificates and if user do not pass the server_cert directory then script will use hardcoded certificates. |
hrushikesh430
force-pushed
the
feat/add_local_server_in_esp_encrypted_ota_pytest
branch
from
3112760 to
39f6f86
Compare
1. Added the python based HTTPS server in pytest to start the https server locally. 2. Updated the README.md file 3. Fixed some cosmetic changes in test_local_server_ota.c
hrushikesh430
force-pushed
the
feat/add_local_server_in_esp_encrypted_ota_pytest
branch
from
39f6f86 to
5f3d865
Compare
mahavirj
reviewed
Jan 14, 2025
| @@ -8,4 +8,4 @@ CONFIG_ESP_HTTPS_OTA_DECRYPT_CB=y | |||
| # Certificate bundle configuration | |||
| CONFIG_MBEDTLS_CERTIFICATE_BUNDLE_DEFAULT_CMN=y | |||
| CONFIG_MBEDTLS_CUSTOM_CERTIFICATE_BUNDLE=y | |||
| CONFIG_MBEDTLS_CUSTOM_CERTIFICATE_BUNDLE_PATH="server_certs/ca_cert.pem" | |||
| CONFIG_MBEDTLS_CUSTOM_CERTIFICATE_BUNDLE_PATH="main/tests/certs/servercert.pem" | |||
There was a problem hiding this comment.
Would the command from README update this file? If not, then how the new server certificate would be embedded on firmware side?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description