Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action prevents running outside of espressif's organization (RDT-1127) #36

Open
3 tasks done
mbainter opened this issue Feb 3, 2025 · 3 comments
Open
3 tasks done

Comments

@mbainter
Copy link

mbainter commented Feb 3, 2025

Checklist

  • Checked the issue tracker for similar issues to ensure this is not a duplicate
  • Read the documentation to confirm the issue is not addressed there and your configuration is set correctly
  • Tested with the latest version to ensure the issue hasn't been fixed

How often does this bug occurs?

always

Expected behavior

Workflow attempts to sync to jira

Actual behavior (suspected bug)

Aborts the sync with:

❌ Not an Espressif repo, nothing to sync to JIRA

Because of this:

if not os.environ['GITHUB_REPOSITORY'].startswith('espressif/'):
print('❌ Not an Espressif repo, nothing to sync to JIRA')
return

Error logs or terminal output

See above

Steps to reproduce the behavior

  1. Configure sync-jira-actions in a repository outside of the espressif organization
  2. Create a new issue

Project release version

v1.0

System architecture

Intel/AMD 64-bit (modern PC, older Mac)

Operating system

Linux

Operating system version

N/A

Shell

sh

Additional context

No response

@github-actions github-actions bot changed the title Action prevents running outside of espressif's organization Action prevents running outside of espressif's organization (RDT-1127) Feb 3, 2025
@kumekay
Copy link
Collaborator

kumekay commented Feb 4, 2025

Hello @mbainter, thank you for opening this issue.

This set of actions has existed for more than six years, dating back to the early days of GitHub Actions. As a result, it still uses some obsolete patterns, such as relying on environment variables instead of inputs. Additionally, it contains some Espressif-specific hardcoded JIRA IDs that may only be valid for our on-premise Jira deployment.

That said, it is possible to overcome these limitations and make the actions more suitable for general use. We are planning a major refactor (v2), but at this point, I cannot provide a specific time frame.

@mbainter
Copy link
Author

mbainter commented Feb 5, 2025

Yeah, I already forked it to try to work past that step and ran into the other pieces. Even so, I'm just looking for a lightweight solution and this fits the bill with some tweaking. Are you open to pull requests that would make this an easier lift for other teams to use?

@kumekay
Copy link
Collaborator

kumekay commented Feb 5, 2025

@mbainter Sure, if the change won't break it for existing users, contributions are welcome, our guide is here: https://github.com/espressif/sync-jira-actions/blob/v1/CONTRIBUTING.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants