source-oracle-flashback: float types with precision < 18 are not string #2212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdibaiee
changed the title
mdibaiee
force-pushed
the
mahdi/float-discovery
branch
from
fc8aceb to
087807e
Compare
mdibaiee
force-pushed
the
mahdi/float-discovery
branch
from
2f5adeb to
6ceb859
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
decimal.Decimal, which is then encoded as a JSON string. This is applied on all numeric types. When doing discovery, we were correctly discoveringNUMBERcolumns with a precision of less than 18 astype: number, and those with a higher precision astype: string, format: number, but we were not doing the same thing forFLOATtypes (DOUBLE PRECISIONis an alias forFLOAT(126)). Updated that code so that discovery's behavior matches the emitted values.Workflow steps:
(How does one use this feature, and how has it changed)
Documentation links affected:
(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)
Notes for reviewers:
(anything that might help someone review this PR)
This change is