diff --git a/source-zendesk-support/acmeCo/posts.schema.yaml b/source-zendesk-support/acmeCo/posts.schema.yaml index bbba9262d0..a62662278c 100644 --- a/source-zendesk-support/acmeCo/posts.schema.yaml +++ b/source-zendesk-support/acmeCo/posts.schema.yaml @@ -19,6 +19,7 @@ properties: type: - "null" - number + - string featured: type: - "null" diff --git a/source-zendesk-support/acmeCo/ticket_metrics.schema.yaml b/source-zendesk-support/acmeCo/ticket_metrics.schema.yaml index cf0799c8f6..a49563ff81 100644 --- a/source-zendesk-support/acmeCo/ticket_metrics.schema.yaml +++ b/source-zendesk-support/acmeCo/ticket_metrics.schema.yaml @@ -126,6 +126,15 @@ properties: type: - "null" - integer + reply_time_in_seconds: + type: + - "null" + - object + properties: + calendar: + type: + - "null" + - integer requester_updated_at: type: - "null" diff --git a/source-zendesk-support/acmeCo/ticket_skips.schema.yaml b/source-zendesk-support/acmeCo/ticket_skips.schema.yaml index d4f4345ea0..bfc6e2d289 100644 --- a/source-zendesk-support/acmeCo/ticket_skips.schema.yaml +++ b/source-zendesk-support/acmeCo/ticket_skips.schema.yaml @@ -63,9 +63,14 @@ properties: - "null" - integer value: + items: + type: + - "null" + - string type: - "null" - string + - array type: - "null" - object diff --git a/source-zendesk-support/source_zendesk_support/schemas/ticket_skips.json b/source-zendesk-support/source_zendesk_support/schemas/ticket_skips.json index 581dbe72d3..d23d5e99d1 100644 --- a/source-zendesk-support/source_zendesk_support/schemas/ticket_skips.json +++ b/source-zendesk-support/source_zendesk_support/schemas/ticket_skips.json @@ -75,9 +75,16 @@ ] }, "value": { + "items": { + "type": [ + "null", + "string" + ] + }, "type": [ "null", - "string" + "string", + "array" ] } }, diff --git a/source-zendesk-support/tests/snapshots/snapshots__capture__capture.stdout.json b/source-zendesk-support/tests/snapshots/snapshots__capture__capture.stdout.json index dd7ef7e84b..45242520c2 100644 --- a/source-zendesk-support/tests/snapshots/snapshots__capture__capture.stdout.json +++ b/source-zendesk-support/tests/snapshots/snapshots__capture__capture.stdout.json @@ -75,17 +75,19 @@ "uuid": "DocUUIDPlaceholder-329Bb50aa48EAa9ef" }, "created_at": "2024-07-26T15:41:00Z", - "details": null, + "details": "", "domain_names": [], "external_id": null, "group_id": null, "id": 28835714737428, "name": "Estuary", - "notes": null, + "notes": "", "organization_fields": {}, "shared_comments": false, "shared_tickets": false, - "tags": [], + "tags": [ + "test-tag" + ], "updated_at": "redacted", "url": "https://d3v-estuary.zendesk.com/api/v2/organizations/28835714737428.json" } @@ -301,8 +303,8 @@ "row_id": 0, "uuid": "DocUUIDPlaceholder-329Bb50aa48EAa9ef" }, - "count": 1, - "name": "assembly" + "name": "redacted", + "count": 1 } ], [ diff --git a/source-zendesk-support/tests/snapshots/snapshots__discover__capture.stdout.json b/source-zendesk-support/tests/snapshots/snapshots__discover__capture.stdout.json index c6110edc96..6fe0cd58f8 100644 --- a/source-zendesk-support/tests/snapshots/snapshots__discover__capture.stdout.json +++ b/source-zendesk-support/tests/snapshots/snapshots__discover__capture.stdout.json @@ -3369,9 +3369,16 @@ ] }, "value": { + "items": { + "type": [ + "null", + "string" + ] + }, "type": [ "null", - "string" + "string", + "array" ] } }, diff --git a/source-zendesk-support/tests/test_snapshots.py b/source-zendesk-support/tests/test_snapshots.py index 9d0751c3c2..cd6b1fb242 100644 --- a/source-zendesk-support/tests/test_snapshots.py +++ b/source-zendesk-support/tests/test_snapshots.py @@ -30,13 +30,20 @@ def test_capture(request, snapshot): seen.add(stream) for l in unique_stream_lines: - _, rec = l[0], l[1] + stream, rec = l[0], l[1] rec['_meta']['row_id'] = 0 if "updated_at" in rec: rec["updated_at"] = "redacted" if "last_login_at" in rec: rec["last_login_at"] = "redacted" + if stream == "acmeCo/tags": + rec["name"] = "redacted" + # Updating count with rec["count"] = 1 sets count to be + # the tuple [1] instead of the int 1. We can get around + # this by deleting the attribute then re-setting it. + del rec["count"] + rec["count"] = 1 assert snapshot("capture.stdout.json") == unique_stream_lines