Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting Bindings Should Remove Checkpoints #22

Open
dyaffe opened this issue Nov 18, 2022 · 0 comments
Open

Deleting Bindings Should Remove Checkpoints #22

dyaffe opened this issue Nov 18, 2022 · 0 comments

Comments

@dyaffe
Copy link
Member

dyaffe commented Nov 18, 2022

Problem
Currently when a binding is deleted, we don't delete checkpoints and therefore if you re-add the binding, the materialization re-starts from where it left off. We do delete the actual underlying data (like the table) most of the time though, so this leads to only partial data being re-materialized.

Proposal
We should very carefully delete checkpoints when bindings are deleted. I say very carefully, cause removing checkpoints is extremely dangerous if we do it incorrectly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant