Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backfill counter includes disabled collections in the count #1267

Open
travjenkins opened this issue Sep 24, 2024 · 1 comment
Open

Backfill counter includes disabled collections in the count #1267

travjenkins opened this issue Sep 24, 2024 · 1 comment
Labels
blocked Progress on the issue cannot ensue until a decision is made. bug Something isn't working

Comments

@travjenkins
Copy link
Member

travjenkins commented Sep 24, 2024

Bug
If you have an entity with disabled collections these are included. These should not be included as it can make it seem like the count of X of Y bindings is off. This is especially true when enabling ALL bindings as it can then look like more bindings are able to be backfilled than can be.

Expected
Only enabled bindings are included in the count

To fully implement this we'll need to handle better when a user is enabling a previously disabled binding. As if they click "Backfill All" with some bindings disabled and then go enable a binding... that binding won't be marked. However, since it is recently enabled we could just show the toggle as checked anyway. As this is what will happen from the user's perspective.

Screenshots
N/A

Desktop (please complete the following information):
N/A

Additional context
N/A

@travjenkins travjenkins added the bug Something isn't working label Sep 24, 2024
@travjenkins travjenkins self-assigned this Sep 24, 2024
@travjenkins travjenkins removed their assignment Sep 25, 2024
@kiahna-tucker kiahna-tucker self-assigned this Nov 15, 2024
@kiahna-tucker
Copy link
Member

BLOCKED: The client needs a way to know which bindings are new to the specification and which of the existing bindings were enabled (ref: flow issue 1783).

@kiahna-tucker kiahna-tucker added the blocked Progress on the issue cannot ensue until a decision is made. label Nov 20, 2024
@kiahna-tucker kiahna-tucker removed their assignment Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Progress on the issue cannot ensue until a decision is made. bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants