Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated usage of node _headers #49

Closed
JoaquinFernandez opened this issue Apr 20, 2020 · 2 comments
Closed

Deprecated usage of node _headers #49

JoaquinFernandez opened this issue Apr 20, 2020 · 2 comments
Labels

Comments

@JoaquinFernandez
Copy link

Describe the bug

According to Node.js Deprecated APIs, OutgoingMessage.prototype._headers in v12 has been deprecated and on the other hand i see some deprecation logs while using Axios.

(node:89822) [DEP0066] DeprecationWarning: OutgoingMessage.prototype._headers is deprecated

To Reproduce
Calling an endpoint in Node.js v12

Environment:

Phin Version: 3.4.1
OS: OSX 10.15

Related Links

https://stackoverflow.com/questions/56697360/how-to-fix-node12388-dep0066-deprecationwarning-outgoingmessage-prototype
https://nodejs.org/api/deprecations.html#deprecations_dep0066_outgoingmessage_prototype_headers_outgoingmessage_prototype_headernames
http-party/http-server#537

@ethan7g ethan7g added the Bug label May 16, 2020
@ethan7g
Copy link
Owner

ethan7g commented May 16, 2020

Odd. To my knowledge, _headers is not being accessed directly by Phin or Centra. I assume this is a mistake on the part of the implementation of the warning message.

@ethan7g
Copy link
Owner

ethan7g commented Dec 30, 2020

Closing til further confirmation is available. I don’t think Phin or Centra access _headers, so perhaps this was an issue with another package.

@ethan7g ethan7g closed this as completed Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants