Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nat] Log warning when no path to test is included #183

Open
scharissis opened this issue Feb 17, 2025 · 0 comments
Open

[nat] Log warning when no path to test is included #183

scharissis opened this issue Feb 17, 2025 · 0 comments
Labels
A-test-runner Area: Test runner

Comments

@scharissis
Copy link
Contributor

When a test is referenced without including its full package path NAT must search for it. This dramatically lengthens the runtime.
When this happens we should log a warning, ideally with the path to be included, as a prompt for the user to add it. Ideally this will remind them to add it before they merge the new test(s) to main.

Example (bad):

tests:
          - name: TestWallet

Example (good):

tests:
          - name: TestWallet
            package: github.com/ethereum-optimism/optimism/devnet-sdk/system
@scharissis scharissis added the A-test-runner Area: Test runner label Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-test-runner Area: Test runner
Projects
None yet
Development

No branches or pull requests

1 participant