Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect SuperchainERC20 address in README (at least when building locally) #152

Closed
karlfloersch opened this issue Sep 18, 2024 · 1 comment · Fixed by #153
Closed

Incorrect SuperchainERC20 address in README (at least when building locally) #152

karlfloersch opened this issue Sep 18, 2024 · 1 comment · Fixed by #153

Comments

@karlfloersch
Copy link

Bug Description
The README says the predeployed SuperERC20 address is 0x61a6eF395d217eD7C79e1B84880167a417796172 but when I investigated it seemed to be getting deployed to 0xA301B4dbc64c5BDA1f128186B1D084246E964F13

Steps to Reproduce

Building and running supersim

  1. git clone ...supersim...
  2. just generate-genesis
  3. just build-go
  4. just build-contracts
  5. go build cmd/main.go
  6. ./main --interop.autorelay
$ ./main --interop.autorelay 
INFO [09-18|11:15:27.229] starting supersim
INFO [09-18|11:15:27.401] configuring interop contracts
INFO [09-18|11:15:27.401] starting L2ToL2CrossDomainMessenger autorelayer
INFO [09-18|11:15:27.408] supersim is ready
INFO [09-18|11:15:27.413] 
...

Testing Example B

I try to follow the tutorial and run

cast send 0x61a6eF395d217eD7C79e1B84880167a417796172 "mint(address _to, uint256 _amount)"  0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92266 1000  --rpc-url http://127.0.0.1:9545 --private-key 0xac0974bec39a17e36ba4a6b4d238ff944bacb478cbed5efcae784d7bf4f2ff80

However, there is no code at this contract address. Tested this with:

cast code 0x61a6eF395d217eD7C79e1B84880167a417796172 --rpc-url http://127.0.0.1:9546
0x

But when I use cast send 0xA301B4dbc64c5BDA1f128186B1D084246E964F13 ... the tutorial works as expected.

Expected behavior
Expected the tutorial to work!

Environment Information:

  • Operating System: OSX
  • Package Version daa397a

Additional context
I would love to have a section in the readme on building & running Supersim locally. It used to have that info but it got removed recently it seems.


⚠️ Notice: Issues that do not include the following sections will be subject to closure:

  • Bug Description
  • Steps to Reproduce
  • Environment Information

Please ensure all required sections are filled out accurately to expedite the debugging process and improve issue resolution efficiency.

@jakim929
Copy link
Contributor

thx for reporting! put out a fix here #153 and also an issue for longer term issue. #154

also added back how to build / run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants