-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EIP: Precompile Falcon512 generic verifier #8190
Conversation
File
|
There is already draft EIP7592: Precompile for Falcon Signature Verification You may want to combine efforts for a Falcon signature verification precompile. |
Signed-off-by: eum602 <[email protected]>
Signed-off-by: eum602 <[email protected]>
Co-authored-by: Andrew B Coathup <[email protected]>
Signed-off-by: eum602 <[email protected]>
Signed-off-by: eum602 <[email protected]>
Signed-off-by: eum602 <[email protected]>
It looks like the implementation of Falcon is MIT licensed: https://github.com/PQClean/PQClean/blob/master/crypto_sign/falcon-512/clean/LICENSE You could copy that directory into |
Thank you will do that way @SamWilsn |
Signed-off-by: eum602 <[email protected]>
The commit bee79f3 (as a parent of 780aee0) contains errors. |
Signed-off-by: eum602 <[email protected]>
Done @SamWilsn , the implementation was added in assets/eip-7619 . All checks have passed |
There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review. |
I have addressed all required feedback and am ready for a review. |
There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review. |
everything else looks good i am not sure if we would want huge implementation and testvectors in the EIP assets. what do you think @SamWilsn |
There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review. |
This pull request was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback or request a review in a comment. |
Is there anything else we can do to move this PR to the next step? |
Very interesting approach used, I'm trying to use it |
Propose to add a generic Postquantum signature verification algorithm based on Falcon-512.