You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
confirmAndCheck returns either true or false depending on whether or not the function call has been approved by M-of-N owners. However, regardless of return value, it makes important state changes that count the confirmations received thus far. The new implementation of onlymanyowners reverts state changes (via require) any time confirmAndCheck returns false, making it impossible to hit the confirmation threshold for any function. No tallying ever happens.
This makes it impossible to change any of the wallet's properties such as ownership, required confirmations, etc.
The text was updated successfully, but these errors were encountered:
brynbellomy
changed the title
Change to onlymanyowners modifier breaks administrative functions
Change to onlymanyowners modifier breaks administrative functions
Aug 27, 2017
brynbellomy
changed the title
Change to onlymanyowners modifier breaks administrative functions
Wallet.sol: change to onlymanyowners modifier breaks administrative functions
Aug 27, 2017
I think the most recent change to wallet.sol broke all of the administrative functions (i.e., those with the
onlymanyowners
modifier).See relevant commit + line: 2849dab#diff-ed99a3039a35a9961cc9c6735a7099baR49
confirmAndCheck
returns either true or false depending on whether or not the function call has been approved by M-of-N owners. However, regardless of return value, it makes important state changes that count the confirmations received thus far. The new implementation ofonlymanyowners
reverts state changes (viarequire
) any timeconfirmAndCheck
returns false, making it impossible to hit the confirmation threshold for any function. No tallying ever happens.This makes it impossible to change any of the wallet's properties such as ownership, required confirmations, etc.
The text was updated successfully, but these errors were encountered: