Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet.sol: change to onlymanyowners modifier breaks administrative functions #81

Open
brynbellomy opened this issue Aug 27, 2017 · 2 comments

Comments

@brynbellomy
Copy link

I think the most recent change to wallet.sol broke all of the administrative functions (i.e., those with the onlymanyowners modifier).

See relevant commit + line: 2849dab#diff-ed99a3039a35a9961cc9c6735a7099baR49

confirmAndCheck returns either true or false depending on whether or not the function call has been approved by M-of-N owners. However, regardless of return value, it makes important state changes that count the confirmations received thus far. The new implementation of onlymanyowners reverts state changes (via require) any time confirmAndCheck returns false, making it impossible to hit the confirmation threshold for any function. No tallying ever happens.

This makes it impossible to change any of the wallet's properties such as ownership, required confirmations, etc.

@brynbellomy brynbellomy changed the title Change to onlymanyowners modifier breaks administrative functions Change to onlymanyowners modifier breaks administrative functions Aug 27, 2017
@brynbellomy brynbellomy changed the title Change to onlymanyowners modifier breaks administrative functions Wallet.sol: change to onlymanyowners modifier breaks administrative functions Aug 27, 2017
@brynbellomy
Copy link
Author

I can PR a fix if someone on your team can confirm the bug

@illuzen
Copy link

illuzen commented Aug 30, 2017

You guys don't have any unit tests?...

loredanacirstea added a commit to raiden-network/raiden-token that referenced this issue Sep 29, 2017
- parity wallet is not usable anymore when doing confirmations: ethereum/dapp-bin#81
- Gnosis multisig - added tests for 2/3 confirmations
- fixed LogHandler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants