You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The v4 identity scheme defined in the ENR spec uses signatures consisting of only r and s, not v. eth-keys currently does not allow verification of signatures without v.
How can it be fixed?
Suggested approach:
Implement ecdsa_verify in all backends without falling back to ecdsa_recover
Allow instantiation of Signature with an (r, s) tuple and/or a 64 byte signature. All recover methods should raise some kind of exception (ValidationError?) if v is not set.
The text was updated successfully, but these errors were encountered:
Wondering if we could segregate this into two classes so that rather than having APIs that might raise an error, you instead decide what type of signature you are working with and don't have to do any value checking.
Signature -> RecoverableSignature
We can figure out how to deal with names and the existing signature class if we like this approach.
What was wrong?
The v4 identity scheme defined in the ENR spec uses signatures consisting of only
r
ands
, notv
.eth-keys
currently does not allow verification of signatures withoutv
.How can it be fixed?
Suggested approach:
ecdsa_recover
Signature
with an(r, s)
tuple and/or a 64 byte signature. All recover methods should raise some kind of exception (ValidationError
?) ifv
is not set.The text was updated successfully, but these errors were encountered: