Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞(gentest): generate test cases as a state_test for single transactions #864

Open
Tracked by #866
danceratopz opened this issue Oct 2, 2024 · 1 comment · May be fixed by #903
Open
Tracked by #866

🐞(gentest): generate test cases as a state_test for single transactions #864

danceratopz opened this issue Oct 2, 2024 · 1 comment · May be fixed by #903
Labels
scope:gentest Scope: gentest CLI type:bug Something isn't working

Comments

@danceratopz
Copy link
Member

Currently, gentest generates test cases in the blockchain_test format.

However, if a test case can be expressed as a state_test, state_test is the preferred format. This is because:

  • fill will additionally generate a blockchain_test fixture from state-tests (consisting of one block and one transaction).
  • The state_test format provides more targeted testing, as it does not invoke a client's block building machinery (for exception tests, this can lead to false positives, see Zero max_fee_per_blob_gas test is ineffective #343).

Bonus points for adding this rationale to EEST's HTML documentation in "Writing Tests" 🙂.

@danceratopz danceratopz changed the title 🐞(gentest): generate test cases in the state_test for single transactions 🐞(gentest): generate test cases as a state_test for single transactions Oct 2, 2024
@danceratopz danceratopz added type:bug Something isn't working scope:gentest Scope: gentest CLI labels Oct 2, 2024
@raxhvl
Copy link
Contributor

raxhvl commented Oct 19, 2024

Picking this up next.

@raxhvl raxhvl linked a pull request Oct 21, 2024 that will close this issue
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:gentest Scope: gentest CLI type:bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants