Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

std::evm functions should take buffer types #891

Closed
g-r-a-n-t opened this issue May 25, 2023 · 5 comments
Closed

std::evm functions should take buffer types #891

g-r-a-n-t opened this issue May 25, 2023 · 5 comments
Labels
comp: std-lib good first issue Good for newcomers

Comments

@g-r-a-n-t
Copy link
Member

g-r-a-n-t commented May 25, 2023 •
edited
Loading

What is wrong?

A number of functions defined in std::evm take offsets and lengths for regions of memory and calldata. These should take buffer types instead.

How can it be fixed

  • implement CalldataBuffer, CalldataBufferReader
  • update revert_mem, return_mem, call_data_copy, code_copy, ext_code_copy, keccak256_mem, create, create2, call, and log

run $ cargo test std_lib to check changes made to crates/library
saifalkatout pushed a commit to saifalkatout/fe that referenced this issue May 31, 2023
@saifkatoutatcom
ethereum#891 Call functions
4910a3a 
Fixed call functions of the ethereum#891 issue.
saifalkatout pushed a commit to saifalkatout/fe that referenced this issue Jun 4, 2023
@saifkatoutatcom
ethereum#891 part 2
202f26a 
return_mem, revert_mem, log, keccak256_mem, create
saifalkatout pushed a commit to saifalkatout/fe that referenced this issue Jun 10, 2023
@saifkatoutatcom
std::evm functions should take buffer types ethereum#891 (Part 1)
969d73f 
fixed comments from ethereum#893
saifalkatout pushed a commit to saifalkatout/fe that referenced this issue Jun 16, 2023
@saifkatoutatcom
snap files
2fa5913 
Snap files for changes on PR ethereum#891
g-r-a-n-t added a commit that referenced this issue Jul 3, 2023
@g-r-a-n-t
Merge pull request #895 from saifalkatout/master
f115178 
std::evm functions should take buffer types #891 (Part 1)
@saifalkatout saifalkatout mentioned this issue Jul 5, 2023
Merged
3 tasks
saifalkatout pushed a commit to saifalkatout/fe that referenced this issue Sep 28, 2023
@saifkatoutatcom @saifalkatout
ethereum#891 Call functions
58a839b 
Fixed call functions of the ethereum#891 issue.
saifalkatout pushed a commit to saifalkatout/fe that referenced this issue Sep 28, 2023
@saifkatoutatcom @saifalkatout
ethereum#891 part 2
5cb106f 
return_mem, revert_mem, log, keccak256_mem, create
saifalkatout pushed a commit to saifalkatout/fe that referenced this issue Sep 28, 2023
@saifkatoutatcom @saifalkatout
std::evm functions should take buffer types ethereum#891 (Part 1)
5a521bb 
fixed comments from ethereum#893
saifalkatout pushed a commit to saifalkatout/fe that referenced this issue Sep 28, 2023
@saifkatoutatcom @saifalkatout
snap files
c219769 
Snap files for changes on PR ethereum#891
saifalkatout pushed a commit to saifalkatout/fe that referenced this issue Sep 28, 2023
@saifkatoutatcom @saifalkatout
ethereum#891 Call functions
fae5474 
Fixed call functions of the ethereum#891 issue.
saifalkatout pushed a commit to saifalkatout/fe that referenced this issue Sep 28, 2023
@saifkatoutatcom @saifalkatout
ethereum#891 part 2
ecd17a3 
return_mem, revert_mem, log, keccak256_mem, create
saifalkatout pushed a commit to saifalkatout/fe that referenced this issue Sep 28, 2023
@saifkatoutatcom @saifalkatout
std::evm functions should take buffer types ethereum#891 (Part 1)
0309020 
fixed comments from ethereum#893
saifalkatout pushed a commit to saifalkatout/fe that referenced this issue Sep 28, 2023
@saifkatoutatcom @saifalkatout
snap files
53f1817 
Snap files for changes on PR ethereum#891
@Hrushi20
Copy link

Hey, can I work on this issue? Can you give me a brief idea about CalldataBuffer and CalldataBufferReader, so that I can start working on this issue.

@g-r-a-n-t
Copy link
Member Author

hey sorry for the late reply @Hrushi20

this work has been completed, but I could help you find another task if you're interested

@Hrushi20
Copy link

Hey! I'm interested. Any beginner friendly issues I can get started with?

@g-r-a-n-t
Copy link
Member Author

would you be interested in adding support for the transient storage opcodes?

@g-r-a-n-t
Copy link
Member Author

here, just wrote an issue #978

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp: std-lib good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@g-r-a-n-t @Hrushi20