Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portal Network integration tracking #31092

Open
3 of 7 tasks
GrapeBaBa opened this issue Jan 30, 2025 · 2 comments
Open
3 of 7 tasks

Portal Network integration tracking #31092

GrapeBaBa opened this issue Jan 30, 2025 · 2 comments

Comments

@GrapeBaBa
Copy link
Contributor

GrapeBaBa commented Jan 30, 2025

Rationale

This is a sub task of #30908 , it will track all the portal network integration works.

Implementation

This is the current fork diff, we will make the smallest changes for geth.

@KolbyML
Copy link
Member

KolbyML commented Jan 30, 2025

#30581 @KolbyML will make a spec PR.

I was referring to what I would do if I was you,

#30581 (comment)

Hmm. We have an explicit test that verifies the current Geth behavior, the node is supposed to respond to every handshake attempt with a new WHOAREYOU challenge.

This is also explicitly mentioned by the spec, in the Handshake Implementation Considerations section (sentence beginning with "Another important issue is the processing...")

I'm curious if this happens often. Possibly we could change the spec.

I was agreeing with this ^. I don't have time to make a PR to update that spec at the moment, currently my focus is benchmarking trin

@GrapeBaBa
Copy link
Contributor Author

@KolbyML Got it. Here I need to confirm if you agree with the current behavior in spec? Do we need other implementations (rust, nim) to modify according to the spec?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants