Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use go-ipa for Multiproof point deserialization #392

Open
jsign opened this issue Sep 11, 2023 · 1 comment
Open

Use go-ipa for Multiproof point deserialization #392

jsign opened this issue Sep 11, 2023 · 1 comment

Comments

@jsign
Copy link
Collaborator

jsign commented Sep 11, 2023

Currently, we have some custom code to deserialize a Multiproof. In go-ipa, there's a specific API to do this deserialization.

Both styles are a bit different since go-ipa expects an opaque stream of bytes and does the deserialization. Here, in go-verkle, we have the serialized proof already in parts, which probably explains why we have some custom code.

In any case, we must rely on go-ipa to do any deserialization to know this is done safely. If that means changing go-ipa APIs since we need to pass these "parts", I think that's fine. But let's try to rely on go-ipa for any security issues since it has (and will continue to have) more tests (and audits) to be sure these APIs are safe.

@gballet
Copy link
Member

gballet commented Sep 12, 2023

Yeah this is the old API, it has some issues. We would have to revisit it before we move back to this system. I don't oppose it, but let's keep things as they are now for kaustinen. It's much easier to debug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants