New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible redundant code in proof reconstruction #395

Open

gballet opened this issue Sep 12, 2023 · 0 comments

Member

gballet commented Sep 12, 2023

From @jsign in #384 :

I still feel this if is a bit strange. We're reconstructing the values to be assigned in the leaf when we'll soon create the LeafNode.

But see what we do in CreatePath(...):

We use that value slice as expected.

We do some extra assignments from stemInfo.

Is the latter needed? Or a noop? Or maybe I'm missing something.

This looks like leftover code from a previous version of the tree API. I didn't want to remove it just yet, but it looks like this is redundant.

gballet mentioned this issue

create proofs with post state #384

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment