Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving performance of the Library with Cython #50

Open
Bhargavasomu opened this issue Feb 13, 2019 · 2 comments
Open

Improving performance of the Library with Cython #50

Bhargavasomu opened this issue Feb 13, 2019 · 2 comments

Comments

@Bhargavasomu
Copy link
Contributor

Bhargavasomu commented Feb 13, 2019

What is wrong?

There are many places in the code like, finding an intersection of the tangent with the curve etc. In other words, there are many functions whose variables make use of fixed specific datatypes (mostly int). I feel that Cythonizing these functions would improve the performance.

Maybe tackle this after we have benchmarks for the library.

How can it be fixed

Make the suitable functions as cython functions.

@hwwhww
Copy link
Contributor

hwwhww commented Feb 13, 2019

Agreed! We did consider using Cython to improve performance; especially that Serenity BLS signature aggregation would be one of the highest overhead.

@carver
Copy link
Collaborator

carver commented Mar 23, 2019

Maybe tackle this after we have benchmarks for the library.

I would go as far as saying this is blocked on #49 -- there is no point in starting to optimize performance without a benchmarking suite.

pacrob pushed a commit to pacrob/py_ecc that referenced this issue Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants