Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle standard JSON translation with outputSelection for =<0.4.19 #690

Open
kuzdogan opened this issue May 8, 2023 · 0 comments
Open

Handle standard JSON translation with outputSelection for =<0.4.19 #690

kuzdogan opened this issue May 8, 2023 · 0 comments
Labels
low effort There is not much implementation work to be done. The task is very easy or tiny. low impact Changes are not very noticeable or potential benefits are limited. should have We like the idea but it’s not important enough to be a part of the roadmap.

Comments

@kuzdogan
Copy link
Member

kuzdogan commented May 8, 2023

We've come across an issue while recompiling a contract with 0.4.19 as laid out here: ethereum/sourcify#1017

TLDR: The compiler gives empty JSON output without throwing because the outputSelection fields were introduced in 0.4.18 and updated in 0.4.19.

I believe the outputSelection field needs to be handled by the JSON translator translate.ts of solc-js for the earlier versions.
@kuzdogan kuzdogan mentioned this issue May 11, 2023
Closed
@cameel cameel added bug 🐛 low effort There is not much implementation work to be done. The task is very easy or tiny. low impact Changes are not very noticeable or potential benefits are limited. must have eventually Something we consider essential but not enough to prevent us from releasing Solidity 1.0 without it. should have We like the idea but it’s not important enough to be a part of the roadmap. and removed bug 🐛 must have eventually Something we consider essential but not enough to prevent us from releasing Solidity 1.0 without it. labels Jan 20, 2025
@cameel cameel changed the title Handle standard JSON transalation with outputSelection for =<0.4.19 Handle standard JSON translation with outputSelection for =<0.4.19 Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
low effort There is not much implementation work to be done. The task is very easy or tiny. low impact Changes are not very noticeable or potential benefits are limited. should have We like the idea but it’s not important enough to be a part of the roadmap.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cameel @kuzdogan