[BUG] Order gets created even if paypal redirect fails

[kaysond]

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

1. Use incorrect paypal api keys
2. Complete an order using paypal

Expected behavior
Order should not get added to db

Screenshots
If applicable, add screenshots to help explain your problem.

Background (please complete the following information):

• NodeJS Version - 20.7.0
• Postgres Version - 15.4
• EverShop Version - rc7
• OS: [e.g. Window, Ubuntu, Mac-OS] - Debian
• Browser [e.g. Chrome, Safari] - FF

Additional context
This is problematic because it creates pending orders that reduce stock but can never be paid for

[treoden]

Hi @kaysond ,

The way the checkout works is an order will be created with the "pending" payment status first, and then buyer will be taking care of the payment later
If the payment was successful, the payment status will be updated to "Paid". This is to avoid the race condition like someone can place an order with same product and make it out of stock in the same time the previous guy working on the payment.

I understand this approach can generate pending payment orders and hold stock. Normally we solve this problem by having a job to check and cancel the order has pending payment for so long and release the stock. Since this process depends on the business, we do not make it as a part of the core.

Let me know if you have any question.
Thanks

[kaysond]

@treoden - I figured it was race condition related. Still, I think it might be worth making sure the initial request to the payment processor is successful before creating the db entry. For CoD, the "request" will always go through.

Also, it would help if in the admin panel we could delete orders with pending payments to release the stock manually.

[ultimate-tester]

I support the feature to delete orders, but don't support to only create the order later in the database. I want to see failed orders too, I could contact the customer and have them pay in an alternative way so that the order can go through. Creating order later will miss potential sales.

[kaysond]

This is still an issue. If someone fails the zip code check on stripe, they're unable to actually complete the order, but the stock is still removed. Definitely need to be able to delete orders at a minimum. Maybe #345 will help with the stripe issue?