Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make an embeddable preact component/web app that generates copy-pastable embeds #127

Open
osdiab opened this issue Mar 26, 2021 · 3 comments
Assignees
Labels

Comments

@osdiab
Copy link
Contributor

osdiab commented Mar 26, 2021

Once #124 is in, then we can make a preact component that asks for info about the nonprofit, and spits out a copy-pastable embed, which we can ultimately host from embeds.every.org and also potentially the main Every.org site.

Would be nice if this was exported to npm for our main app to consume. eventually we can also just use API calls to pull most of the requisite data from our API, using the nonprofit slug (and just allow things to be overridden by hadn in this component); it might already work as is but need to check that.

Example URL: https://www.every.org/api/nonprofits/MAPS , and we can already use our Partner Search API to get the nonprofit slugs quickly.

@osdiab
Copy link
Contributor Author

osdiab commented Mar 26, 2021

cc @markulrich @rahulgi @wednesdave

@osdiab osdiab changed the title Make a simple web app that generates a copy-pastable embed Make an embeddable preact component/web app that generates a copy-pastable donate button embed Mar 26, 2021
@osdiab osdiab changed the title Make an embeddable preact component/web app that generates a copy-pastable donate button embed Make an embeddable preact component/web app that generates a copy-pastable embeds Mar 26, 2021
@osdiab osdiab changed the title Make an embeddable preact component/web app that generates a copy-pastable embeds Make an embeddable preact component/web app that generates copy-pastable embeds Mar 26, 2021
@osdiab osdiab added the p1 label Mar 27, 2021
@martinbianchi
Copy link
Contributor

@osdiab I have some doubts about this one.
Should we create this on a new package inside this repo? Or create a new component and export it as we did with #124 ?
Also, about the information that we will ask to generate the embed, we want to get from the non-profit all the information needed to configure the split-layout widget? I'm thinking that maybe we will need some designs if that's the idea

@osdiab
Copy link
Contributor Author

osdiab commented Apr 2, 2021

Yeah, we should definitely design this and also add more helper functionality to auto populate as much of this information as possible from a nonprofit slug. I’ll make some time to spec this out further before we dive in.

@osdiab osdiab self-assigned this Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants