Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OnlyFurus embed didn't work #51

Closed
osdiab opened this issue Jan 28, 2021 · 15 comments
Closed

OnlyFurus embed didn't work #51

osdiab opened this issue Jan 28, 2021 · 15 comments
Labels

Comments

@osdiab
Copy link
Contributor

osdiab commented Jan 28, 2021

Not sure how they embedded it, but they ended up copying the code from our example to do it instead. Figure out why it screwed up.

@osdiab
Copy link
Contributor Author

osdiab commented Jan 28, 2021

looks like the README is outdated

@osdiab
Copy link
Contributor Author

osdiab commented Jan 28, 2021

The Cloudflare worker doesn't show any KV value for onlyfurus, so i would assume they tried to use the assets.every.org/every-month/bundle.js, which was the old version of the donate button (current one is assets.every.org/donate-button-v2/*).

If they were using the dynamic cloudflare assets, they would have gone to assets.every.org/donate-button/{slug}/* and a KV value would have been used - i see how that wouldn't be easily copy-pasteable though, more discussion on a simpler solution at #50

@osdiab
Copy link
Contributor Author

osdiab commented Jan 28, 2021

he says he used "the actual script used in the demo" - which i'm guessing means, he isn't using our assets.every.org CDN at all, it's getting whatever is the built version on the demo page, which isn't going through that URL. which should work i guess lol

@osdiab
Copy link
Contributor Author

osdiab commented Jan 28, 2021

https://every-month.vercel.app/ pulls in https://every-month-bivnx293c.vercel.app/webComponent.js , which i'm pretty sure is old/outdated.

@osdiab
Copy link
Contributor Author

osdiab commented Jan 28, 2021

cc @jake-nz

@osdiab
Copy link
Contributor Author

osdiab commented Jan 28, 2021

i think the Vercel instance is not run by Every.org, it's P22's, so I don't have visibility into the actual build it's running.

@osdiab
Copy link
Contributor Author

osdiab commented Jan 28, 2021

Nonetheless the trick is probably to update the README as per #52

@osdiab
Copy link
Contributor Author

osdiab commented Jan 28, 2021

yup, checking the HTML on onlyfurus.com's NOPE page, that's the one they're using.

@osdiab
Copy link
Contributor Author

osdiab commented Jan 28, 2021

It's possible that it going to one time instead of monthly is also a result of the library being outdated.

@jake-nz
Copy link
Contributor

jake-nz commented Jan 28, 2021

Re Vercel: every-month.vercel.app is now connected to this repo

@markulrich
Copy link
Member

The same bug appears at https://every-month.vercel.app/ - when you donate the link has frequency=ONCE instead of frequency=MONTHLY

@markulrich markulrich added the p1 label Jan 28, 2021
@osdiab
Copy link
Contributor Author

osdiab commented Jan 28, 2021

webComponent.js only appears to be in the old every-month folder, so yeah i would presume they're using an old version.

@jake-nz
Copy link
Contributor

jake-nz commented Feb 1, 2021

Sorry, Vercel has not been updated recently. See my comment here: #54 (comment)

@jake-nz
Copy link
Contributor

jake-nz commented Feb 1, 2021

#44 addresses the MONTHLY vs ONCE bug

@osdiab
Copy link
Contributor Author

osdiab commented Feb 3, 2021

I landed #44 and pushed a new version to the Github pages.

@osdiab osdiab closed this as completed Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants