-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More bulletproof, intuitive options format #73
Comments
we should do this before a lot of people start using the donate button, or else it will be hard to move |
This is the current interface, as I typed out based on the actual usage on site, taken from
|
I'm going to work on this now, by making a beta version of the donate button package to allow for sweeping breaking changes under a new version number, in order to expedite getting a simplified button out that directs people to specifically do crypto donations. |
The options format as is is pretty brittle, with a lot of stuff failing if you don't specify them just right. For example, levels need to be duplicated in multiple places, changing behavior in the i18n blob, and specifying incorrectly can lead to confusing behavior and crashing, when one would assume an i18n blob would be totally optional and only impact display.
With a major version bump let's make a cleaner, less failure-prone options format that better allows for partial inclusion of options and avoid contradictory settings. Using TypeScript will also help us make sure that we don't blow things up unexpectedly. #11
The text was updated successfully, but these errors were encountered: