From e66515f914b63714cc7bb69dd2bf09723e8a50a3 Mon Sep 17 00:00:00 2001 From: Oliver Denman Date: Thu, 18 May 2017 12:04:07 +0100 Subject: [PATCH] Test member data with broken image Instead of recording the url of the member's portrait, the scraper is getting the URL of a PDF icon. Issue: https://github.com/everypolitician/everypolitician-data/issues/33716 --- test/cassettes/wtk_htm.yml | 123 +++++++++++++++++++++++++++++++++++++ test/data/wtk.htm.yml | 21 +++++++ 2 files changed, 144 insertions(+) create mode 100644 test/cassettes/wtk_htm.yml create mode 100644 test/data/wtk.htm.yml diff --git a/test/cassettes/wtk_htm.yml b/test/cassettes/wtk_htm.yml new file mode 100644 index 000000000..c865c116d --- /dev/null +++ b/test/cassettes/wtk_htm.yml @@ -0,0 +1,123 @@ +--- +http_interactions: +- request: + method: get + uri: http://www.legco.gov.hk/general/english/members/yr16-20/wtk.htm + body: + encoding: US-ASCII + string: '' + headers: + Accept-Encoding: + - gzip;q=1.0,deflate;q=0.6,identity;q=0.3 + Accept: + - "*/*" + User-Agent: + - Ruby + response: + status: + code: 200 + message: OK + headers: + Date: + - Thu, 18 May 2017 11:14:16 GMT + Server: + - Apache/2.2.3 (Red Hat) + Last-Modified: + - Thu, 22 Dec 2016 09:17:57 GMT + Etag: + - '"2a600c5-17b6-5443bbeb75b40"' + Accept-Ranges: + - bytes + Content-Length: + - '6070' + X-Ua-Compatible: + - IE=edge + Cache-Control: + - max-age=0, private, no-store, no-cache, must-revalidate + Connection: + - close + Content-Type: + - text/html + Set-Cookie: + - BIGipServerWeb_80_pool=352400138.20480.0000; path=/ + body: + encoding: UTF-8 + string: " + \r\n\r\n + \ \r\n \r\n \r\n + \ \r\n \r\n \r\n \r\n \r\n Legislative + Council of the Hong Kong Special Administrative Region - Members' Biographies + ::Hon WONG Ting-kwong, SBS, JP\r\n\t\r\n + \ \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \t\r\n \r\n + \ \r\n + \ \r\n + \ \r\n + \ \r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n \r\n
\r\n \r\n + \
\r\n
\r\n + \
\r\n + \
\r\n
\r\n\t\t
\r\n\t\t\t\r\n\t\t
\r\n\t\t
\r\n\t\t\t
\r\n\t\t\t\t
\r\n\t\t\t\t\t
\r\n\t\t\t\t\t\t
\t\t\r\n\t\t\t\t\t
\t\t\t\r\n\t\t\t\t
\t\t\r\n\t\t\t\t
\r\n\t\t\t\t\t
\"\"
\t\t\t\t\r\n\t\t\t\t\t\t\t\t\r\n\t\t\t\t\t
\r\n\t\t\t\t\t\r\n\t\t\t\t\t
\t\t\t\t\t\t\r\n\t\r\n
\r\n
\r\n\r\n\"Hon\r\n\r\n\r\n\r\n

Hon WONG Ting-kwong, SBS, JP\r\n

\r\n\r\n\r\n

Constituency :

\r\n
  • Functional + Constituency - Import and Export\r\n
\r\n\r\n\r\n

Education and professional qualifications + :

\r\n
    \r\n
  • Heung To Middle School\r\n
  • Guangzhou + No. 6 High School\r\n
\r\n\r\n\r\n

Occupation + :

\r\n
    \r\n
  • Merchant\r\n
\r\n\r\n\r\n

Political affiliation :

\r\n
    \r\n
  • Democratic + Alliance for the Betterment and Progress of Hong Kong\r\n
\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n
Office address:\r\nRoom + 604, Legislative Council Complex,
\r\n1 Legislative Council Road, Central, + Hong Kong\r\n
Office + telephone:2826 9152
Office fax:2826 9148\r\n
E-mail:tkwong@dab.org.hk\r\n
Résumé:\"PDF\r\n
\r\n

(Information as provided by Member)

\r\n
\r\n
\r\n\t\t\t\t\t\r\n\t\t\t\t\t
\r\n\t\t\t\t
\r\n\t\t\t
\r\n\t\t
\r\n\t + \
\r\n\t \r\n
\r\n\t\t
\r\n + \
\r\n
\r\n + \
\r\n + \
\r\n + \
\t \r\n\t
\r\n \r\n" + http_version: + recorded_at: Thu, 18 May 2017 11:14:16 GMT +recorded_with: VCR 3.0.3 diff --git a/test/data/wtk.htm.yml b/test/data/wtk.htm.yml new file mode 100644 index 000000000..ec8e9a7da --- /dev/null +++ b/test/data/wtk.htm.yml @@ -0,0 +1,21 @@ +--- +:class: MemberPage +:url: http://www.legco.gov.hk/general/english/members/yr16-20/wtk.htm +:to_h: + :id: yr16-20/wtk + :term: yr16-20 + :name: WONG Ting-kwong + :honorific_prefix: Hon + :honorific_suffix: SBS, JP + :gender: + :faction: Democratic Alliance for the Betterment and Progress of Hong Kong + :email: tkwong@dab.org.hk + :website: '' + :phone: 2826 9152 + :fax: 2826 9148 + # TODO: The image is a PDF icon, not the member's photo. + # Issue: https://github.com/everypolitician/everypolitician-data/issues/33716 + :img: http://www.legco.gov.hk/images/english/pdf.gif + :area: Import and Export + :area_type: functional + :source: http://www.legco.gov.hk/general/english/members/yr16-20/wtk.htm