Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eopt/sont should be aliases #24

Open
chrismytton opened this issue Nov 7, 2018 · 0 comments
Open

eopt/sont should be aliases #24

chrismytton opened this issue Nov 7, 2018 · 0 comments

Comments

@chrismytton
Copy link
Contributor

The MembershipComparison::DateHelpers#eopt and MembershipComparison::DateHelpers#sont methods have quite obscure names. I think it would be easier to understand if the methods were called end_of_previous_term and start_of_next_term and then the short versions were aliases of the longer versions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chrismytton