Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin for screen orientation #20

Open
psvensson opened this issue Feb 25, 2016 · 4 comments
Open

Add plugin for screen orientation #20

psvensson opened this issue Feb 25, 2016 · 4 comments

Comments

@psvensson
Copy link

This one, for example;

https://github.com/gbenvenuti/cordova-plugin-screen-orientation

Requested by community

@ghost ghost added this to the Sprint Clara milestone Mar 15, 2016
@ghost ghost self-assigned this Mar 15, 2016
@ghost ghost added the priority-2 label Mar 15, 2016
@ghost ghost added in-progress and removed in-progress labels Mar 22, 2016
@gokr gokr modified the milestones: Sprint Dillon, Sprint Clara Mar 30, 2016
@gokr
Copy link
Contributor

gokr commented Apr 11, 2016

Moving to Fredrika which needs a new viewer most probably.

@gokr gokr modified the milestones: Sprint Fredrika, Sprint Dillon Apr 11, 2016
@ghost ghost added the in-progress label Apr 21, 2016
@ghost
Copy link

ghost commented Apr 21, 2016

Added in this commit: a6d8702

TODO:

  • DONE Make tests to verify that the plugin works. See test results below.
  • Update documentation page with plugin listing (API page)

@ghost
Copy link

ghost commented May 3, 2016

Status update:

Test results for iOS:

  • Report of screen orientation works (screen.orientation, and orientation changed event).
  • Set screen orientation does not work.

Test results for Android:

  • Report of screen orientation does not work.
  • Set screen orientation works.

Conclusion: the plugin is half working on both Android and iOS, with different functionality working/failing on respective platform.

Should we include the plugin given these conditions? The result could be confusion/frustration among users.

@ghost ghost removed the in-progress label May 3, 2016
@ghost ghost changed the title Add plugin for device orientation Add plugin for screen orientation May 5, 2016
@ghost
Copy link

ghost commented May 5, 2016

We concluded to not include the plugin in Viewer 1.4, since it has some issues.

Recommend to revisit the plugin later and investigate status, review bug fixes and do testing.

Removing issue from Sprint Fredrika.

@ghost ghost removed this from the Sprint Fredrika milestone May 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants