Possible oversight when rendering Swiss matches.

[robigan]

The page to view Swiss matches might include a slight oversight wherein it seems to assume that stageItem will always succeed. I see that there is an if check on

bracket/frontend/src/pages/tournaments/[id]/swiss/[stage_item_id].tsx

Line 78 in 48ba51a

if (responseIsValid(swrStagesResponse) && stageItemId != null) {

before fetching additional data but the latter half of the if check is useless as Next will always assure a non-nullable value, and it doesn't actually check that the data exists in the DB to begin with. When a page is requested with an ID that doesn't exist in

bracket/frontend/src/pages/tournaments/[id]/swiss/[stage_item_id].tsx

Lines 78 to 82 in 48ba51a

	if (responseIsValid(swrStagesResponse) && stageItemId != null) {
	stageItem = getStageItemLookup(swrStagesResponse)[stageItemId];
	[activeStage] = getStageById(swrStagesResponse, stageItem.stage_id);
	if (activeStage != null && activeStage.stage_items != null) {

it attempts to query further data, but it fails causing an error to be bubbled up. I would propose moving up the if check, removing the latter half of the check, making the variables defined use the useState hook rather than define them using let and implementing another if check to validate that the correct data is queried.

[github-actions]

This issue is stale because it has been open for 60 days with no activity. What is the action to take here?

[github-actions]

This issue is stale because it has been open for 60 days with no activity. What is the action to take here?