Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DQN get_action method uses target_model, not model. #247

Open
tcfuji opened this issue Jan 11, 2023 · 0 comments · May be fixed by #248
Open

DQN get_action method uses target_model, not model. #247

tcfuji opened this issue Jan 11, 2023 · 0 comments · May be fixed by #248
Assignees
@tcfuji
Labels
bug Something isn't working High Priority

Comments

@tcfuji
Copy link
Collaborator

tcfuji commented Jan 11, 2023 •
edited
Loading

Problem: There is a serious bug in dqn.py in the get_action method in line 269 of the develop branch. This should be self.model, not self.target_model. This problem exists in the main branch too.

I can submit a PR for this but all branches will need to be updated (essential for anyone using dqn.py). Once the PR has been merged, please consider redoing any experiments that use DQN.
@tcfuji tcfuji added bug Something isn't working High Priority labels Jan 11, 2023
@tcfuji tcfuji self-assigned this Jan 11, 2023
This was referenced Jan 12, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tcfuji tcfuji

Labels
bug Something isn't working High Priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed get_action method. exalearn/EXARL
1 participant
@tcfuji