allow notification_methods to be inheritable

[wdiechmann]

Update: on a totally different witch_hunt I came by this so you most certainly can close this one at will - it's either on the roadmap or in the bin with all the Christmas-paper waste 😆

I don't know - maybe it is me not commandeering Noticed right and for that I apologise in advance - but I have

class ApplicationNotifier < NoticedEvent
  deliver_by :turbo_stream, class: "DeliveryMethods::TurboStream"
  deliver_by :web_push, class: "DeliveryMethods::WebPush"

  notification_methods do
    def data
      {
        title: title,
        body: body,
        url: url,
        record_id: record.id,
        record_type: record.class.name
      }
    end
  end

  def title
    params[:title]
  rescue
    "title missing"
  end

  def body
    params[:message]
  rescue
    "message missing"
  end

  def url
    params[:url] || time_materials_path(record)
  rescue
    "/"
  end

end

class PunchNotifier < ApplicationNotifier
  def url
    punches_path(record)
  end
end

I'm used to the OO sweatness of Ruby hence this layout - but seems like Noticed will not recognise me trying to DRY my classes 😞

My subscription seems to be in the festive seasons decoration mode 🎅

12:17:35 web.1  | Processing by Noticed::WebPush::SubscriptionsController#create as */*
12:17:35 web.1  |   Parameters: {"endpoint"=>"https://fcm.googleapis.com/fcm/send/fFqE7OzIxuc:APA91bHp10XIKvtYJfSlhmccxxtgxuTAlsMXixKxK5QuVld4kw0ccbOCtHqbJ0HJyepmsCHUMkQKQhDIJ8mYpbflGGv9nFTXPvETVL9Gq3c5isrnXXqpEz5IqYTpBLn8kn26tEoOzzxk", "expirationTime"=>nil, "keys"=>{"p256dh"=>"BD4oNOowxQ5NSO_Wx7isgzPkMWbNaqjp3WpRlaEGFmmes06y84xi5rmSH_lsXPR0kIy1Nx31jlCQT-BTif3uO-o", "auth"=>"p1d-hccT9hcWF0LsdIJiqA"}, "subscription"=>{"endpoint"=>"https://fcm.googleapis.com/fcm/send/fFqE7OzIxuc:APA91bHp10XIKvtYJfSlhmccxxtgxuTAlsMXixKxK5QuVld4kw0ccbOCtHqbJ0HJyepmsCHUMkQKQhDIJ8mYpbflGGv9nFTXPvETVL9Gq3c5isrnXXqpEz5IqYTpBLn8kn26tEoOzzxk"}}
12:17:35 web.1  | [reader]   User Load (0.1ms)  SELECT "users".* FROM "users" WHERE "users"."id" = ? ORDER BY "users"."id" ASC LIMIT ?  [["id", 31], ["LIMIT", 1]]
12:17:35 web.1  | [reader]   ↳ app/controllers/noticed/web_push/subscriptions_controller.rb:15:in `subscribe'
12:17:35 web.1  | [reader]   Noticed::WebPush::Subscription Load (0.1ms)  SELECT "noticed_web_push_subs".* FROM "noticed_web_push_subs" WHERE "noticed_web_push_subs"."user_type" = ? AND "noticed_web_push_subs"."user_id" = ? AND "noticed_web_push_subs"."endpoint" = ? AND "noticed_web_push_subs"."auth_key" = ? AND "noticed_web_push_subs"."p256dh_key" = ? LIMIT ?  [["user_type", "User"], ["user_id", 31], ["endpoint", "{\"p\":\"zK62IHe1H7VZggQn4y5XYha/ILr7hfnxz2xFnRItJxlwXxwu9XlrI3nKmV5iMQpOCo0ycKW7V5K/KjOm865Ag3NDwl7ETRUca70dvnDbrhtnLcB03CY2vmda52Gxl8m5kvwdeDOFWQ0LNdEXHb69+YMd05DW7dE4gYjpUmWrhIWNNuONWtx9D+HXbRCO+Lbe1vj1Z9SdKPH1OyX8yjhjAYInE3IN9kZSGd+AxQZL\",\"h\":{\"iv\":\"1GhHSFHN59aLA91H\",\"at\":\"HxtjXKHs2UhrPLIm0JZ8uA==\",\"c\":true}}"], ["auth_key", "[FILTERED]"], ["p256dh_key", "[FILTERED]"], ["LIMIT", 1]]
12:17:35 web.1  | [reader]   ↳ app/controllers/noticed/web_push/subscriptions_controller.rb:15:in `subscribe'
12:17:35 web.1  | Completed 200 OK in 53ms (ActiveRecord: 0.5ms (2 queries, 0 cached) | GC: 0.7ms)

But my notification performs poorly 💩

12:19:46 web.1  | [ActiveJob] [DeliveryMethods::WebPush] [cbc8abb4-3d95-4f21-9ec1-e8ae64b926b3] [writer]   ↳ app/notifiers/delivery_methods/web_push.rb:5:in `deliver'
12:19:46 web.1  | [ActiveJob] [DeliveryMethods::WebPush] [cbc8abb4-3d95-4f21-9ec1-e8ae64b926b3] Error performing DeliveryMethods::WebPush (Job ID: cbc8abb4-3d95-4f21-9ec1-e8ae64b926b3) from Async(default) in 27.16ms: NoMethodError (undefined method `data' for an instance of TimeMaterialNotifier::Notification):
12:19:46 web.1  | /Users/walther/.asdf/installs/ruby/3.3.3/lib/ruby/gems/3.3.0/bundler/gems/rails-4944454d5fb9/activemodel/lib/active_model/attribute_methods.rb:512:in `method_missing'

(if I introduce the notification_methods on the PunchNotifier class all is good)

Is it on me - or maybe a feature for Future Christmas 😄

[excid3]

Using notification_methods on ApplicationNotifier will add to ApplicationNotifier::Notification which isn't the parent class of PunchNotifier::Notification.

We can probably handle that by changing the inheritance chain to support that.

[wdiechmann]

that would solve another minor issue with the definition of classes and later usage - changing the inheritance chain

defining PunchNotifier and later "looking for" PunchNotifier::Notification is - let's say an acquired tast 😉