Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy to NPM #7

Open
ScreamingHawk opened this issue Apr 11, 2022 · 6 comments
Open

Deploy to NPM #7

ScreamingHawk opened this issue Apr 11, 2022 · 6 comments

Comments

@ScreamingHawk
Copy link

ERC721A is available on NPM, which makes it easy to include in projects managed with npm/yarn.
https://www.npmjs.com/package/erc721a
It would be awesome to see ERC721R available in this way as well.

@elie222
Copy link
Contributor

elie222 commented Apr 11, 2022

hey, we'd have to adjust the structure a bit to make that work but agreed.

currently it's code snippets you can add to your own project but if we turn it into a contract you inherit this would work.
we need to see the best way to implement this as there are a few different forms this contract could take. with cryptofighters having two price points we had to store more info than we would have had to for a regular contract using refunds. but we'll try find a generic solution that covers many cases. or have a few different formats for erc721r that people can use

@lawweiliang
Copy link
Contributor

@ScreamingHawk and @elie222 ,

We are definitely going to create a npm package for ERC721R. I will put it in my task list.
Good suggestion.

@lawweiliang
Copy link
Contributor

lawweiliang commented Apr 14, 2022

@ScreamingHawk and @elie222 ,

I had created an npm package for ERC721R.
https://www.npmjs.com/package/erc721r

@elie222
Copy link
Contributor

elie222 commented Apr 14, 2022

Awesome. We have a PR being worked on that will help here: #16

@lawweiliang
Copy link
Contributor

Awesome. We have a PR being worked on that will help here: #16

@elie222 , you share message in wrong place.
Issue here is related to NPM deployment. Not relate to any owner mint function.

I believe you are trying to share the message over issue #12 😄

@elie222
Copy link
Contributor

elie222 commented Apr 15, 2022

It wasn't a mistake. Right now the npm package doesn't do anything as there's no contract to inherit from for your own project. But as we extract the core refund functionality into its own contract the npm package will become useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants