Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new error types, fix error reporting #44

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Aryk
Copy link

@Aryk Aryk commented Dec 10, 2021

I think this would be a better candidate for a new major or minor release as I've removed the deprecated methods.

Refering to #43

This library has had very little development it seems in the past year and doesn't support some error reporting at all such as PUSH_TOO_MANY_EXPERIENCE_IDS.

I attempted to leave all the old non-deprecated functionality the same and got all the test cases passing to ensure no regression. Also removed and cleaned up other things in the code.

Here are the things I changed:

  1. Added support for PUSH_TOO_MANY_EXPERIENCE_IDS (including tests) and Internal Server Error error so you'll actually see if you are getting that error.
  2. Whenever there is an unknown error, I always add the actual error message onto it so you can see what exactly failed in the code. I also pass through the details into the error message so you know what went wrong by the error message.
  3. Allow the ability to pass in options for Typheous.post so you don't have to pass in a different HTML client, so for example you can now pass in ssl_verifypeer: false to get the gem working in AWS if you are in that environment.
  4. Removed the deprecated methods.

Aryk added 4 commits December 9, 2021 11:23
1. Added support for PUSH_TOO_MANY_EXPERIENCE_IDS error so you'll actually see if you are getting that error.
2. Whenever there is an unknown error, I always add the actual error message onto it so you can see what exactly failed in the code. I also pass through the details into the error message so you know what went wrong by the error message.
3. Allow the ability to pass in options for Typheous.post so you don't have to pass in a different HTML client, so for example you can now pass in `ssl_verifypeer: false` to get the gem working in AWS if you are in that environment.
4. Removed the deprecated methods.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant