Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoincrement buildNumber with Github Actions #2116

Closed
quotentiroler opened this issue Nov 9, 2023 · 2 comments
Closed

Autoincrement buildNumber with Github Actions #2116

quotentiroler opened this issue Nov 9, 2023 · 2 comments
Labels
enhancement New feature or request needs review Issue is ready to be reviewed by a maintainer

Comments

@quotentiroler
Copy link

Do you understand that any feature requests opened in this repository will be closed?

Yes

@quotentiroler quotentiroler added enhancement New feature or request needs review Issue is ready to be reviewed by a maintainer labels Nov 9, 2023
@quotentiroler
Copy link
Author

Hello, some time has passed now since this topic was discussed but it seems that it is still impossible to use autoincrement on buildNumber together with github actions, unless there is some fancy workaround for the commit.

Since expo builds run on expo server, why is it necessary to overwrite the app.json file with the autoincrement set true? It would make more sense to autoincrement buildNumber only on the expo server if set to true and not overwrite app.json at all since the only reason why developers want autoincrement is to not have the same buildNumber twice in the expo builds, in order to successfully run eas submit. If the buildNumber is specified, it can be used, but if not and autoincrement is true, it should just autoincrement on the server, not in the repo.

Thanks for considering my suggestion.

@brentvatne
Copy link
Member

hi @quotentiroler - you are right, you don't need to overwrite the value! I recommend setting up remote version management as described here: https://docs.expo.dev/build-reference/app-versions/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs review Issue is ready to be reviewed by a maintainer
Projects
None yet
Development

No branches or pull requests

2 participants