Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fingerprint inconsistencies when using EAS Secret File in app.config.ts #2482

Closed
pmk1c opened this issue Aug 7, 2024 · 1 comment
Closed
Labels
needs review Issue is ready to be reviewed by a maintainer

Comments

@pmk1c
Copy link

pmk1c commented Aug 7, 2024

Build/Submit details page URL

https://expo.dev/accounts/zweitag/projects/farmpartner-app/builds/e8a8fd89-3058-4d0d-8f47-728218c9ec26

Summary

We setup the google services file using a EAS secret file. The relevant part of the app.config.ts looks like this:

{
    android: {
      googleServicesFile:
        process.env.GOOGLE_SERVICES_JSON_FILE ?? "./google-services.json",
      ...,
    },
    ...,
}

This leads to fingerprint inconsistencies between local and EAS fingerprint. This makes sense, since the EAS secret file will lead to a random file path in the app config on EAS.

I guess the fix would be to use a EAS secret with the file content and paste it into a file google-services.json before running EAS. But I think it should also be possible to use a EAS secret file here.

One way to fix this would be, to add an option to ignore arbitrary config keys from the app config to fingerprint.config.ts.

Managed or bare?

managed

Environment

expo-env-info 1.2.0 environment info:
System:
OS: macOS 14.5
Shell: 5.9 - /bin/zsh
Binaries:
Node: 20.13.1 - ~/.asdf/installs/nodejs/20.13.1/bin/node
npm: 10.5.2 - ~/.asdf/plugins/nodejs/shims/npm
Watchman: 2024.05.06.00 - /opt/homebrew/bin/watchman
Managers:
CocoaPods: 1.15.2 - /Users/ruben.grimm/.asdf/shims/pod
SDKs:
iOS SDK:
Platforms: DriverKit 23.5, iOS 17.5, macOS 14.5, tvOS 17.5, visionOS 1.2, watchOS 10.5
IDEs:
Android Studio: 2023.3 AI-233.14808.21.2331.11842104
Xcode: 15.4/15F31d - /usr/bin/xcodebuild
npmPackages:
expo: ^51.0.24 => 51.0.24
react: 18.2.0 => 18.2.0
react-native: ^0.74.3 => 0.74.3
npmGlobalPackages:
eas-cli: 9.1.0
Expo Workflow: managed

Error output

No response

Reproducible demo or steps to reproduce from a blank project

  1. Create a new expo project.
  2. Add a EAS secret file.
  3. Use process.env.SECRET_FILE in the app.config.ts.
@pmk1c pmk1c added the needs review Issue is ready to be reviewed by a maintainer label Aug 7, 2024
@pmk1c
Copy link
Author

pmk1c commented Aug 8, 2024

I think I missed the fact, that the fingerprint does not use the config value, but the whole file content of google-services.json. Now I understand, that I need to add the same contents on the local CI as on EAS. That makes sense.

@pmk1c pmk1c closed this as completed Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review Issue is ready to be reviewed by a maintainer
Projects
None yet
Development

No branches or pull requests

1 participant