-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eas-cli@11 breaks environment variable resolution #2519
Comments
+1 Experiencing the same issue |
Same here, we are trying to access the env-vars that are set by |
… from eas build command (#2521) <!-- If this PR requires a changelog entry, add it by commenting the PR with the command `/changelog-entry [breaking-change|new-feature|bug-fix|chore] [message]`. --> <!-- You can skip the changelog check by labeling the PR with "no changelog". --> # Why #2519 I was able to reproduce the issue and it is indeed true. It seems like we mistakenly added a static project config definition to the `eas build` command context in 56510f0#diff-cd2e00f4d286a4714f8736e14c635f4c3b98c402367cd71a83e4cd743034bd79. The output from it wasn't really used anywhere, but adding it caused the app configs to be evaluated without `buildProfile.env` in the first pass when trying the resolve project ID and slug at the begging of command execution and our slug/project ID assertions to fail. It only affected people with dynamic project IDs and slug fields. # How Remove unnecessary static context from context definitions, therefore avoid resolving project ID and slug from app config without env vars as a first thing when the `eas build` command is executed. # Test Plan Tested manually
Thanks for the report! I was able to replicate the issue. This was indeed an unintended change, sorry about this. We added a static app config context definition to the #2521 should fix it. It seems like the issue affected projects with dynamic slug/projectId fields in |
Thank you for filing this issue! |
The issue should be fixed in version |
I switched the |
Well done Expo team! |
Build/Submit details page URL
No response
Summary
I have an eas.json like so:
and so on. In v10, these environment variables are correctly given to app.config.ts to do its job of building a dynamic environment aware config. In version 11, this has stopped working an no environment variables are defined, breaking generation of app.config.
Managed or bare?
managed
Environment
Error output
Project config: Slug for project identified by "extra.eas.projectId" (myapp-flavora) does not match the "slug" field (myapp-undefined). Learn more
Reproducible demo or steps to reproduce from a blank project
I do not yet have one. This is a pretty major undocumented breaking change, so would love to either get a rationale or place to look first.
The text was updated successfully, but these errors were encountered: