feat!: Make load/create/update/delete entity authorization result int…

…erfaces consistent (#253)
expo · Feb 24, 2025 · 4d56065 · 4d56065
1 parent 275c63d
commit 4d56065
Show file tree

Hide file tree

Showing 42 changed files with 1,044 additions and 359 deletions.
diff --git a/...ges/entity-cache-adapter-local-memory/src/__tests__/GenericLocalMemoryCacher-full-test.ts b/...ges/entity-cache-adapter-local-memory/src/__tests__/GenericLocalMemoryCacher-full-test.ts
@@ -26,9 +26,10 @@ describe(GenericLocalMemoryCacher, () => {
 
     const date = new Date();
     const entity1Created = await LocalMemoryTestEntity.creator(viewerContext)
+      .enforcing()
       .setField('name', 'blah')
       .setField('dateField', date)
-      .enforceCreateAsync();
+      .createAsync();
 
     // loading an entity should put it in cache
     const entity1 = await LocalMemoryTestEntity.loader(viewerContext)
@@ -103,9 +104,10 @@ describe(GenericLocalMemoryCacher, () => {
 
     const date = new Date();
     const entity1Created = await LocalMemoryTestEntity.creator(viewerContext)
+      .enforcing()
       .setField('name', 'blah')
       .setField('dateField', date)
-      .enforceCreateAsync();
+      .createAsync();
 
     // loading an entity will try to put it in cache but it's a noop cache, so it should be a miss
     const entity1 = await LocalMemoryTestEntity.loader(viewerContext)

diff --git a/...ache-adapter-redis/src/__integration-tests__/BatchedRedisCacheAdapter-integration-test.ts b/...ache-adapter-redis/src/__integration-tests__/BatchedRedisCacheAdapter-integration-test.ts
@@ -104,8 +104,9 @@ describe(GenericRedisCacher, () => {
     const cacheKeyMaker = genericCacher['makeCacheKey'].bind(genericCacher);
 
     const entity1Created = await RedisTestEntity.creator(viewerContext)
+      .enforcing()
       .setField('name', 'blah')
-      .enforceCreateAsync();
+      .createAsync();
 
     // loading an entity should put it in cache. load by multiple requests and multiple fields in same tick to ensure batch works
     mgetSpy.mockClear();

diff --git a/...cache-adapter-redis/src/__integration-tests__/GenericRedisCacher-full-integration-test.ts b/...cache-adapter-redis/src/__integration-tests__/GenericRedisCacher-full-integration-test.ts
@@ -47,8 +47,9 @@ describe(GenericRedisCacher, () => {
     const cacheKeyMaker = genericCacher['makeCacheKey'].bind(genericCacher);
 
     const entity1Created = await RedisTestEntity.creator(viewerContext)
+      .enforcing()
       .setField('name', 'blah')
-      .enforceCreateAsync();
+      .createAsync();
 
     // loading an entity should put it in cache
     const entity1 = await RedisTestEntity.loader(viewerContext)
@@ -99,7 +100,10 @@ describe(GenericRedisCacher, () => {
     );
     const date = new Date();
     const entity1 = await enforceAsyncResult(
-      RedisTestEntity.creator(viewerContext).setField('dateField', date).createAsync(),
+      RedisTestEntity.creator(viewerContext)
+        .withAuthorizationResults()
+        .setField('dateField', date)
+        .createAsync(),
     );
     expect(entity1.getField('dateField')).toEqual(date);
 
@@ -121,7 +125,10 @@ describe(GenericRedisCacher, () => {
       createRedisIntegrationTestEntityCompanionProvider(genericRedisCacheContext),
     );
     const entity1 = await enforceAsyncResult(
-      RedisTestEntity.creator(viewerContext).setField('name', '').createAsync(),
+      RedisTestEntity.creator(viewerContext)
+        .withAuthorizationResults()
+        .setField('name', '')
+        .createAsync(),
     );
     const entity2 = await RedisTestEntity.loader(viewerContext)
       .enforcing()

diff --git a/...tity-cache-adapter-redis/src/__integration-tests__/GenericRedisCacher-integration-test.ts b/...tity-cache-adapter-redis/src/__integration-tests__/GenericRedisCacher-integration-test.ts
@@ -47,9 +47,10 @@ describe(GenericRedisCacher, () => {
     );
     const date = new Date();
     const entity1Created = await RedisTestEntity.creator(viewerContext)
+      .enforcing()
       .setField('name', 'blah')
       .setField('dateField', date)
-      .enforceCreateAsync();
+      .createAsync();
     const testKey = `test-id-key-${entity1Created.getID()}`;
     const objectMap = new Map<string, Readonly<RedisTestEntityFields>>([
       [testKey, entity1Created.getAllFields()],
@@ -93,9 +94,10 @@ describe(GenericRedisCacher, () => {
     );
     const date = new Date();
     const entity1Created = await RedisTestEntity.creator(viewerContext)
+      .enforcing()
       .setField('name', 'blah')
       .setField('dateField', date)
-      .enforceCreateAsync();
+      .createAsync();
     const testKey = `test-id-key-${entity1Created.getID()}`;
     const objectMap = new Map<string, Readonly<RedisTestEntityFields>>([
       [testKey, entity1Created.getAllFields()],

diff --git a/packages/entity-cache-adapter-redis/src/__integration-tests__/errors-test.ts b/packages/entity-cache-adapter-redis/src/__integration-tests__/errors-test.ts
@@ -40,7 +40,7 @@ describe(GenericRedisCacher, () => {
     );
 
     await expect(
-      RedisTestEntity.creator(vc1).setField('name', 'blah').enforceCreateAsync(),
+      RedisTestEntity.creator(vc1).enforcing().setField('name', 'blah').createAsync(),
     ).rejects.toThrow(EntityCacheAdapterTransientError);
   });
 });