chore: internal refactor of loader to be structured like new mutation methods #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #254 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 78 78
Lines 2033 2029 -4
Branches 278 278
=========================================
- Hits 2033 2029 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
wschurman
force-pushed
the
@wschurman/02-19-chore_internal_refactor_of_loader_to_be_structured_like_new_mutation_methods
branch
2 times, most recently
from
e7e4cc7 to
adc8658
Compare
This was referenced Feb 20, 2025
quinlanj
approved these changes
Feb 20, 2025
This was referenced Feb 20, 2025
wschurman
changed the base branch from
@wschurman/02-19-feat_make_load/create/update/delete_entity_authorization_result_interfaces_consistent
to
graphite-base/254
wschurman
force-pushed
the
@wschurman/02-19-chore_internal_refactor_of_loader_to_be_structured_like_new_mutation_methods
branch
from
adc8658 to
02c5ac3
Compare
wschurman
deleted the
@wschurman/02-19-chore_internal_refactor_of_loader_to_be_structured_like_new_mutation_methods
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
After implementing #253 I noticed that the new pattern of the enforcing/withAuthorizationResult layer was quite a bit simpler the way I did it for the mutators than the way it was done for the loader.
This PR updates the loader to use the same pattern, where it is purely a concept for the entity class (user API) rather than used by any of the backing utilities/mutators/etc. Those all operate on the result loader and use enforce methods when needed.
How
Refactor internals. Note that this doesn't change the external API for loading.
Test Plan
This has full test coverage.