-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Default all loaders and mutators to enforcing #256
base: main
Are you sure you want to change the base?
feat!: Default all loaders and mutators to enforcing #256
Conversation
3c5172c
to
da53893
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #256 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 80 80
Lines 2053 2070 +17
Branches 277 282 +5
=========================================
+ Hits 2053 2070 +17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
da53893
to
9189649
Compare
9189649
to
49742c0
Compare
49742c0
to
4742ba8
Compare
1e7d917
to
01b2606
Compare
01b2606
to
7be217a
Compare
4742ba8
to
32ccd3d
Compare
857a69b
to
828daef
Compare
32ccd3d
to
e072e65
Compare
828daef
to
c6f74a1
Compare
e072e65
to
7bfa3cb
Compare
Will land this once v0.40.0 is stabilized and has been out for a little while. Will also write a codemod in the |
7bfa3cb
to
b211f6b
Compare
9d27f21
to
d63ddd6
Compare
b211f6b
to
7ca3847
Compare
7ca3847
to
d3a4a60
Compare
Why
Note: this should probably be released as a new major version, which is 1.0.0 (!).
This addresses the comment on #253:
The reason this is possible now is that after the breaking change from that PR, it is a typescript error breaking change instead of an implicit breaking change to default the loaders/mutations to the enforcing versions.
How
The new CRUD interface for entity will look like:
Test Plan
Full test coverage.