-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Add enforcing entity association loader #257
feat!: Add enforcing entity association loader #257
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #257 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 78 80 +2
Lines 2029 2053 +24
Branches 278 277 -1
=========================================
+ Hits 2029 2053 +24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
61ffc23
to
1e7d917
Compare
I imagine we'll also want to make enforcing() be the default for association loaders too. |
1e7d917
to
863332f
Compare
863332f
to
adcaf3b
Compare
f624836
to
3ce8e42
Compare
adcaf3b
to
0e75f7f
Compare
Why
This adds an enforcing version of the entity association loader and makes the association loader have a similar pattern to loads/mutations.
Before this PR:
After this PR:
This also moves the
queryContext
arg into theassociationLoader
call to match the other loader/mutator methods more closely.How
Using a similar pattern to loaders and mutators, wrap the result-based association loader in an enforcing wrapper.
Test Plan
Full test coverage.