Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Terms and Conditions for Mapbox's locator overlay #1617

Open
eneerhut opened this issue Nov 19, 2024 · 2 comments
Open

Move Terms and Conditions for Mapbox's locator overlay #1617

eneerhut opened this issue Nov 19, 2024 · 2 comments
Assignees
Labels
feature-ui Issue or request related to the user interface design

Comments

@eneerhut
Copy link

eneerhut commented Nov 19, 2024

Description

We currently show and Terms and Conditions link the bottom right hand corner that links to Mapbox. It's not clear to the user what the link relates to and it doesn't even link to terms currently.
image

Some options to consider:

  1. Display terms and conditions behind an 'I' if we are allowed to (proposed by @bhousel).
  2. Utilize Meta's Canterbury style so that we can show labels at low zoom levels. Could ask Jonah for some advice here and it would mean we can swap out Mapbox's locator overlay. Examples below from Mapillary:

image
image

@eneerhut eneerhut self-assigned this Nov 19, 2024
@bhousel
Copy link
Contributor

bhousel commented Nov 19, 2024

Good idea - I've never been really happy with how we show attributions for overlay layers.

If the user adds more overlays, we add more attributions down in this section, and it's not clear which overlay goes with which attribution text. I also put the MapWithAI attribution text here too.

Screenshot 2024-11-19 at 2 12 39 PMScreenshot 2024-11-19 at 2 12 48 PM

I think we could probably move them to a separate popup screen behind an ℹ️ button.

One other point about the Mapbox overlay - I'm fine with swapping it out for something else, but we currently only support raster for this, not vector, and it includes some roads and places and other details too. Not sure whether that would be a dealbreaker, (cc @jonahadkins)

@jonahadkins
Copy link

woof wrt the current terms! 🐶

iirc using the raster services requires a discovery mechanism to get the users country and language to adhere to policy. there would probably need to be some type of access token as well so we identify requests from Rapid. there may also be some 1P/3P concerns from legal. all doable, but would need to drive this internally.

@bhousel bhousel added feature-usability Issue or feature related to usability - something hard to do feature-ui Issue or request related to the user interface design and removed feature-usability Issue or feature related to usability - something hard to do labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-ui Issue or request related to the user interface design
Projects
None yet
Development

No branches or pull requests

3 participants