From 3e8199742279420bae8b69a03d394c92eb989df7 Mon Sep 17 00:00:00 2001 From: Zhaolong Zhu Date: Mon, 19 Feb 2024 17:27:43 -0800 Subject: [PATCH] alerts: make it compatible with Python3.8 (#838) Summary: `re.Pattern[str]` is not valid in Python 3.8 Pull Request resolved: https://github.com/facebook/sapling/pull/838 Test Plan: ``` Python 3.8.17 (default, Jul 9 2023, 20:57:35) [Clang 14.0.3 (clang-1403.0.22.14.1)] on darwin Type "help", "copyright", "credits" or "license" for more information. >>> import re >>> from typing import Optional >>> show_after_crashes_regex: Optional[re.Pattern[str]] = None Traceback (most recent call last): File "", line 1, in TypeError: 'type' object is not subscriptable >>> show_after_crashes_regex: Optional[re.Pattern] = None >>> ``` Reviewed By: zzl0 Differential Revision: D53903964 fbshipit-source-id: 412f4ad5d6011b0da70c47f31f6c919b9c6a8037 --- eden/scm/sapling/alerts.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/eden/scm/sapling/alerts.py b/eden/scm/sapling/alerts.py index fd4fa1ec33d6c..910c1c2ec83bb 100644 --- a/eden/scm/sapling/alerts.py +++ b/eden/scm/sapling/alerts.py @@ -17,7 +17,7 @@ class Alert(NamedTuple): description: str key: str show_in_isl: bool - show_after_crashes_regex: Optional[re.Pattern[str]] + show_after_crashes_regex: Optional[re.Pattern] def parse_alert(ui, key: str, raw_alert: dict) -> Optional[Alert]: