From 42136beb39106d6e30f23d30df8a43475a404001 Mon Sep 17 00:00:00 2001 From: Chris Dinh Date: Tue, 4 Feb 2025 13:47:42 -0800 Subject: [PATCH] Add basic remediation advice to LowDiskSpace(MacOS) Problem in doctor Summary: This diff adds a basic remediation message to LowDiskSpace Problem and moves the help text of LowDiskSpaceMacOS to the remediation message. This is being done because LowDiskSpace Problems were being counted as a Problem without a defined fix. This change makes them Manual Fix problems. Reviewed By: MichaelCuevas Differential Revision: D69066997 fbshipit-source-id: 16961efc6e185432172ccd02b16a3c1062d838c1 --- eden/fs/cli/doctor/check_filesystems.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/eden/fs/cli/doctor/check_filesystems.py b/eden/fs/cli/doctor/check_filesystems.py index 8f7b81d3f48bd..e16e4937a06cc 100644 --- a/eden/fs/cli/doctor/check_filesystems.py +++ b/eden/fs/cli/doctor/check_filesystems.py @@ -213,7 +213,8 @@ def get_mount_pts_set( class LowDiskSpace(Problem): def __init__(self, message: str, severity: ProblemSeverity) -> None: - super().__init__(message, severity=severity) + remediation_msg = "Check your disk usage and free up space." + super().__init__(message, remediation=remediation_msg, severity=severity) class LowDiskSpaceMacOS(Problem): @@ -226,12 +227,12 @@ class LowDiskSpaceMacOS(Problem): util_purge = "eden du --purgeable" def __init__(self, message: str, severity: ProblemSeverity) -> None: - addtl_msg = ( + remediation_msg = ( f"\nA significant portion of your disk may be used up by purgeable " f"space. You can check and clear purgeable space with: \n\n'{self.util_purge}'\n\n" f"See https://fburl.com/edenfs_purgeable for more info.\n" ) - super().__init__(message + addtl_msg, severity=severity) + super().__init__(message, remediation=remediation_msg, severity=severity) def check_disk_usage(