From 34a98c677c9e0cb5030f3e485fab4260c7cab96d Mon Sep 17 00:00:00 2001 From: Michael Lee Date: Thu, 9 Jan 2025 09:06:28 -0800 Subject: [PATCH] codemod `TARGETS -> BUCK` for `fizz/backend` Summary: Covers `fizz/backend` The codemod is ``` $ find fbcode/fizz -name BUCK \ | xargs -I{} sh -c 'if [[ -f $(dirname {})/TARGETS ]]; then hg rm {}; hg mv "$(dirname {})/TARGETS" {} && sed -i "s:^cpp_:fizz_cpp_:" {} && arc buildozer "new_load fbsource//xplat/fizz:defs.bzl fizz_cpp_library fizz_cpp_unittest" "$(dirname {}):__pkg__"; fi' \ && arc f ``` Reviewed By: mingtaoy Differential Revision: D67952848 fbshipit-source-id: 12a4846e6c4bfda88435577d6d17839b03bbaa1a --- fizz/backend/BUCK | 133 ------------------ fizz/backend/liboqs/test/BUCK | 14 -- fizz/backend/openssl/certificate/test/BUCK | 13 -- fizz/backend/openssl/crypto/aead/test/BUCK | 22 --- .../backend/openssl/crypto/exchange/test/BUCK | 22 --- .../openssl/crypto/signature/test/BUCK | 45 ------ fizz/backend/openssl/crypto/test/BUCK | 27 ---- 7 files changed, 276 deletions(-) delete mode 100644 fizz/backend/BUCK delete mode 100644 fizz/backend/liboqs/test/BUCK delete mode 100644 fizz/backend/openssl/certificate/test/BUCK delete mode 100644 fizz/backend/openssl/crypto/aead/test/BUCK delete mode 100644 fizz/backend/openssl/crypto/exchange/test/BUCK delete mode 100644 fizz/backend/openssl/crypto/signature/test/BUCK delete mode 100644 fizz/backend/openssl/crypto/test/BUCK diff --git a/fizz/backend/BUCK b/fizz/backend/BUCK deleted file mode 100644 index 244b30d862a..00000000000 --- a/fizz/backend/BUCK +++ /dev/null @@ -1,133 +0,0 @@ -load("@fbcode_macros//build_defs:cpp_library.bzl", "cpp_library") - -oncall("secure_pipes") - -cpp_library( - name = "libaegis", - srcs = [ - "libaegis/AEGISCipher.cpp", - ], - headers = [ - "libaegis/LibAEGIS.h", - ], - deps = [ - "//fizz/crypto/aead:cryptoutil", - "//folly/lang:checked_math", - ] + select({ - "DEFAULT": [ - "fbsource//third-party/libaegis:aegis", - ], - # @fb-only: "ovr_config//toolchain/fb:arista": [], - }), - exported_deps = [ - "//fizz:config", - "//fizz/crypto:crypto", - "//fizz/crypto/aead:aead", - ], -) - -cpp_library( - name = "liboqs", - srcs = [ - "liboqs/OQSKeyExchange.cpp", - ], - headers = [ - "liboqs/LibOQS.h", - "liboqs/OQSKeyExchange.h", - ], - exported_deps = [ - "fbsource//third-party/liboqs:oqs", - "//fizz:config", - "//fizz/crypto:crypto", - "//fizz/crypto/exchange:key_exchange", - "//folly:memory", - ], -) - -cpp_library( - name = "openssl", - srcs = [ - "openssl/certificate/CertUtils.cpp", - "openssl/crypto/OpenSSLKeyUtils.cpp", - "openssl/crypto/Sha.cpp", - "openssl/crypto/aead/OpenSSLEVPCipher.cpp", - "openssl/crypto/exchange/OpenSSLKeyExchange.cpp", - "openssl/crypto/signature/Signature.cpp", - ], - headers = [ - "openssl/Hasher.h", - "openssl/OpenSSL.h", - "openssl/Properties.h", - "openssl/certificate/CertUtils.h", - "openssl/certificate/CertUtils-inl.h", - "openssl/certificate/OpenSSLPeerCertImpl.h", - "openssl/certificate/OpenSSLPeerCertImpl-inl.h", - "openssl/certificate/OpenSSLSelfCertImpl.h", - "openssl/certificate/OpenSSLSelfCertImpl-inl.h", - "openssl/crypto/ECCurve.h", - "openssl/crypto/OpenSSL.h", - "openssl/crypto/OpenSSLKeyUtils.h", - "openssl/crypto/Sha.h", - "openssl/crypto/aead/OpenSSLEVPCipher.h", - "openssl/crypto/aead/OpenSSLEVPCipher-inl.h", - "openssl/crypto/exchange/OpenSSLKeyExchange.h", - "openssl/crypto/signature/Signature.h", - "openssl/crypto/signature/Signature-inl.h", - ], - deps = [ - "//fizz/crypto/aead:cryptoutil", - "//folly/lang:checked_math", - ], - exported_deps = [ - "//fizz:config", - "//fizz/compression:certificate_compressor", - "//fizz/crypto:crypto", - "//fizz/crypto:hasher", - "//fizz/crypto:hkdf", - "//fizz/crypto/aead:aead", - "//fizz/crypto/aead:iobuf", - "//fizz/crypto/exchange:key_exchange", - "//fizz/protocol:certificate", - "//fizz/record:record", - "//folly:conv", - "//folly:memory", - "//folly:range", - "//folly:string", - "//folly/io:iobuf", - "//folly/io/async/ssl:openssl_transport_certificate", - "//folly/lang:assume", - "//folly/lang:bits", - "//folly/portability:openssl", - "//folly/ssl:openssl_cert_utils", - "//folly/ssl:openssl_hash", - "//folly/ssl:openssl_ptr_types", - ], - exported_external_deps = [ - "glog", - ("openssl", None, "crypto"), - ], -) - -cpp_library( - name = "libsodium", - srcs = [ - "libsodium/crypto/exchange/X25519.cpp", - ], - headers = [ - "libsodium/LibSodium.h", - "libsodium/crypto/exchange/X25519.h", - ], - deps = [ - "//folly:conv", - ], - exported_deps = [ - "//fizz/crypto:crypto", - "//fizz/crypto/exchange:key_exchange", - "//folly:optional", - "//folly:range", - "//folly/io:iobuf", - ], - exported_external_deps = [ - ("libsodium", None, "sodium"), - ], -) diff --git a/fizz/backend/liboqs/test/BUCK b/fizz/backend/liboqs/test/BUCK deleted file mode 100644 index e0e83343974..00000000000 --- a/fizz/backend/liboqs/test/BUCK +++ /dev/null @@ -1,14 +0,0 @@ -load("@fbcode_macros//build_defs:cpp_unittest.bzl", "cpp_unittest") - -oncall("secure_pipes") - -cpp_unittest( - name = "oqs_key_exchange_test", - srcs = [ - "OQSKeyExchangeTest.cpp", - ], - deps = [ - "//fizz/backend:liboqs", - "//folly/portability:gtest", - ], -) diff --git a/fizz/backend/openssl/certificate/test/BUCK b/fizz/backend/openssl/certificate/test/BUCK deleted file mode 100644 index 037e05c488a..00000000000 --- a/fizz/backend/openssl/certificate/test/BUCK +++ /dev/null @@ -1,13 +0,0 @@ -load("@fbcode_macros//build_defs:cpp_unittest.bzl", "cpp_unittest") - -oncall("secure_pipes") - -cpp_unittest( - name = "cert_utils_test", - srcs = ["CertUtilsTest.cpp"], - deps = [ - "//fizz/backend:openssl", - "//fizz/protocol/test:cert_test_types", - "//folly/portability:gtest", - ], -) diff --git a/fizz/backend/openssl/crypto/aead/test/BUCK b/fizz/backend/openssl/crypto/aead/test/BUCK deleted file mode 100644 index ef78ffc6a0d..00000000000 --- a/fizz/backend/openssl/crypto/aead/test/BUCK +++ /dev/null @@ -1,22 +0,0 @@ -load("@fbcode_macros//build_defs:cpp_unittest.bzl", "cpp_unittest") - -oncall("secure_pipes") - -cpp_unittest( - name = "evpciphers", - srcs = [ - "EVPCipherTest.cpp", - ], - supports_static_listing = False, - deps = [ - "//fizz:config", - "//fizz/crypto/aead:iobuf", - "//fizz/crypto/aead/test:data", - "//fizz/crypto/aead/test:test_util", - "//fizz/crypto/test:TestUtil", - "//fizz/record:record", - "//folly:exception_wrapper", - "//folly:string", - "//folly/portability:gtest", - ], -) diff --git a/fizz/backend/openssl/crypto/exchange/test/BUCK b/fizz/backend/openssl/crypto/exchange/test/BUCK deleted file mode 100644 index b08d41033d3..00000000000 --- a/fizz/backend/openssl/crypto/exchange/test/BUCK +++ /dev/null @@ -1,22 +0,0 @@ -load("@fbcode_macros//build_defs:cpp_unittest.bzl", "cpp_unittest") - -oncall("secure_pipes") - -cpp_unittest( - name = "ECKey", - srcs = [ - "ECKeyExchangeTest.cpp", - ], - supports_static_listing = False, - deps = [ - "//fizz/backend:openssl", - "//fizz/crypto/test:TestKeys", - "//fizz/crypto/test:TestUtil", - "//folly:string", - "//folly/portability:gtest", - "//folly/ssl:openssl_ptr_types", - ], - external_deps = [ - ("openssl", None, "crypto"), - ], -) diff --git a/fizz/backend/openssl/crypto/signature/test/BUCK b/fizz/backend/openssl/crypto/signature/test/BUCK deleted file mode 100644 index c60cf98758e..00000000000 --- a/fizz/backend/openssl/crypto/signature/test/BUCK +++ /dev/null @@ -1,45 +0,0 @@ -load("@fbcode_macros//build_defs:cpp_unittest.bzl", "cpp_unittest") - -oncall("secure_pipes") - -cpp_unittest( - name = "ec", - srcs = [ - "ECSignatureTest.cpp", - ], - supports_static_listing = False, - deps = [ - "//fizz/backend:openssl", - "//folly:string", - "//folly/portability:gtest", - ], -) - -cpp_unittest( - name = "ed", - srcs = [ - "EdSignatureTest.cpp", - ], - headers = [ - "EdSignatureTest.h", - ], - supports_static_listing = False, - deps = [ - "//fizz/backend:openssl", - "//fizz/crypto/test:TestUtil", - "//folly:fixed_string", - "//folly:string", - "//folly/portability:gtest", - ], -) - -cpp_unittest( - name = "rsa_pss", - srcs = [ - "RSAPSSSignatureTest.cpp", - ], - deps = [ - "//fizz/backend:openssl", - "//folly/portability:gtest", - ], -) diff --git a/fizz/backend/openssl/crypto/test/BUCK b/fizz/backend/openssl/crypto/test/BUCK deleted file mode 100644 index 76be47caa66..00000000000 --- a/fizz/backend/openssl/crypto/test/BUCK +++ /dev/null @@ -1,27 +0,0 @@ -load("@fbcode_macros//build_defs:cpp_unittest.bzl", "cpp_unittest") - -oncall("secure_pipes") - -cpp_unittest( - name = "hmac_test", - srcs = [ - "Hmac.cpp", - ], - deps = [ - "//fizz/backend:openssl", - "//fizz/crypto/test:HmacTest", - "//folly/portability:gtest", - ], -) - -cpp_unittest( - name = "key_utils", - srcs = [ - "OpenSSLKeyUtilsTest.cpp", - ], - deps = [ - "//fizz/backend:openssl", - "//fizz/crypto/test:TestUtil", - "//folly/portability:gtest", - ], -)