Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interpretation of validation results #11

Open
Dongzhikang opened this issue Feb 10, 2024 · 2 comments
Open

Interpretation of validation results #11

Dongzhikang opened this issue Feb 10, 2024 · 2 comments

Comments

@Dongzhikang
Copy link

Dear author, I really appreciate your work. I was able to reproduce validation on EgoMCQ test. After validation, I found there are two lines of output in info.log

2024-02-10 16:52:08,386 - trainer - INFO - EgoClip epoch -1, Intra-video, Acc: 90.9; EgoClip epoch -1, Inter-video, Acc: 60.7;
2024-02-10 16:52:09,525 - trainer - INFO - EgoClip epoch -1, Intra-video, Acc: 90.5; EgoClip epoch -1, Inter-video, Acc: 59.6;

I have two questions:

  1. Are there typos about "Intra-video" and "Inter-video"? Because this is not consistent with the results in your paper.
  2. It seems like the first line of output is the results in paper, how to interpret the second line of output?
@ShramanPramanick
Copy link
Contributor

Hi @Dongzhikang,

I'm glad you could resolve the errors and reproduce the results. Please find the answers below:

  1. Good catch. In the current version, I mistakenly swapped the keywords 'Inter-video' and 'Intra-video' while logging the results. I will update this soon.
  2. The first printed line, EgoClip epoch -1, Intra-video, Acc: 90.9; EgoClip epoch -1, Inter-video, Acc: 60.7, is the results achieved by the ensemble of dual-encoder and fusion-encoder. The second printed line, EgoClip epoch -1, Intra-video, Acc: 90.5; EgoClip epoch -1, Inter-video, Acc: 59.6, is the result obtained by the fusion-encoder. We have reported these results in the last row of Table 8.

@ShramanPramanick
Copy link
Contributor

ShramanPramanick commented Mar 22, 2024

The 'Inter-video' and 'Intra-video' keywords are now updated to be consistent. Please let me know if you have any further questions, and feel free to close the issue if it is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants