Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick start and Getting started documentation issue #964

Open
epiniguin opened this issue Jan 10, 2025 · 2 comments · Fixed by #977
Open

Quick start and Getting started documentation issue #964

epiniguin opened this issue Jan 10, 2025 · 2 comments · Fixed by #977
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@epiniguin
Copy link

There is a piece of code in these doc pages:

CKPT_PATH="/checkpoint/$USER/experiments/$EXPERIMENT_NAME/checkpoints/step_1000"
CKPT_DIR=$(dirname "$CKPT_PATH")
CKPT="checkpoint_$(basename "$CKPT_DIR")"  # e.g., checkpoint_step_1000

I guess the third row should be:

CKPT="checkpoint_$(basename "$CKPT_PATH")"

@epiniguin epiniguin added the documentation Improvements or additions to documentation label Jan 10, 2025
@zyaoj
Copy link
Contributor

zyaoj commented Jan 13, 2025

Hi @epiniguin ! Thanks for reporting this typo. There will be a fix to this documentation later this week bundling with a couple of documentation updates. Will keep you posted.

Don't hesitate to ping us if you found any other typo in the documentation. Thanks again for the help!

@zyaoj zyaoj self-assigned this Jan 14, 2025
@zyaoj zyaoj mentioned this issue Jan 17, 2025
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@epiniguin @zyaoj and others