Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isLoading from redux bug #181

Open
ease-space opened this issue Mar 3, 2019 · 3 comments
Open

isLoading from redux bug #181

ease-space opened this issue Mar 3, 2019 · 3 comments
Labels
invalid question wontfix

Comments

@ease-space
Copy link

ease-space commented Mar 3, 2019 •
edited
Loading

isLoading from redux bug causes looping of the render component in v4.0.0
default
@ScriptedAlchemy
Copy link
Collaborator

Any other debugging info?

@ease-space
Copy link
Author

ease-space commented Mar 4, 2019 •
edited
Loading

Yes. Clone this project https://gitlab.com/yura1994hd/middle/tree/bug_react-universal-coponent. Checout on bug_react-universal-coponent and npm run start:dev:local. After run uncomment code \src\containers\Routes\index.js and reload page http://localhost/basket
default

@ease-space
Copy link
Author

It seems I found the reason. What seems to me to be the fault of the react-router

Good work:
<Route exact path={constants.PATCH_URL_BASKET} component={Basket} />
Looping:
<Route exact path={constants.PATCH_URL_BASKET} component={props => <Basket {...props} />} />

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
invalid question wontfix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ease-space @ScriptedAlchemy