Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1pt] graph-prototype: Review TODO(PORT) comments and PORT_DISABLED macros #114

Closed
frankosterfeld opened this issue Dec 1, 2022 · 4 comments
Closed

[1pt] graph-prototype: Review TODO(PORT) comments and PORT_DISABLED macros #114

frankosterfeld opened this issue Dec 1, 2022 · 4 comments
Labels
documentation Improvements or additions to documentation
Milestone
CALL#4 - OP OpenD...

Comments

@frankosterfeld
Copy link
Contributor

The code contains quite a few TODO(PORT) comments and disabled code using #ifdef PORT_DISABLED.
They can stem from me not being sure on GR's behavior, limitations in GR, etc.

Clarify them, find solutions where possible, report feature requests to GR proper where it would make sense, etc.
@frankosterfeld frankosterfeld moved this to 📋 Backlog in Digitizer Reimplementation Dec 2, 2022
@frankosterfeld frankosterfeld changed the title Review TODO(PORT) comments and PORT_DISABLED macros dev-4.0: Review TODO(PORT) comments and PORT_DISABLED macros Dec 2, 2022
RalphSteinhagen pushed a commit that referenced this issue Dec 2, 2022
@frankosterfeld @wirew0rm
Gr40 port (#108)
9c77498 
* Port of gr-digitizer to GNU Radio 4.0

Make code compile with GR 4.0, latest ROOT and latest Picoscope drivers. Some tests don't pass atm.

open issues/improvements to be followed-up later:
#110
#111
#112
#113 
#114 
#115 
#116 

Co-authored-by: Alexander Krimm <[email protected]>
@RalphSteinhagen RalphSteinhagen changed the title dev-4.0: Review TODO(PORT) comments and PORT_DISABLED macros [] graph-prototype: Review TODO(PORT) comments and PORT_DISABLED macros Jul 15, 2023
@RalphSteinhagen RalphSteinhagen added the documentation Improvements or additions to documentation label Jul 15, 2023
@RalphSteinhagen
Copy link
Member

review if these TODO's are still applicable in graph-prototype/the new GR 4.0

@RalphSteinhagen
Copy link
Member

linked to #113

@RalphSteinhagen RalphSteinhagen changed the title [] graph-prototype: Review TODO(PORT) comments and PORT_DISABLED macros [1pt] graph-prototype: Review TODO(PORT) comments and PORT_DISABLED macros Jul 21, 2023
@RalphSteinhagen
Copy link
Member

I think this can be closed since I found only one remaining PORT_DISABLED reference regarding a logging of a warning message. This should/will be addressed by: #113

@RalphSteinhagen RalphSteinhagen moved this from 📋 Backlog to Finished Implementation (2) in Digitizer Reimplementation May 28, 2024
@RalphSteinhagen RalphSteinhagen moved this from Finished Implementation (2) to ✅ QA-Accepted/Merged (∞) in Digitizer Reimplementation May 28, 2024
@frankosterfeld
Copy link
Contributor Author

This was referring to the old dev-4.0 branch and is of course only relevant if we decide to port any of the blocks in there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
Digitizer Reimplementation
Status: ✅ QA-Accepted/Merged (∞)
Milestone
CALL#4 - OP OpenDigitizer Integration...
Development

No branches or pull requests
2 participants
@frankosterfeld @RalphSteinhagen