Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Gauge Metrics #70

Closed
Dentrax opened this issue Feb 28, 2022 · 21 comments
Closed

Enhance Gauge Metrics #70

Dentrax opened this issue Feb 28, 2022 · 21 comments
Labels
help wanted Extra attention is needed kind/feature New feature or request lifecycle/rotten
Milestone

Comments

@Dentrax
Copy link
Contributor

Dentrax commented Feb 28, 2022

Motivation

Currently, there is only 1 gauge vector metric in falco-exporter, that is falco_events. But it emits string values, I mean, we use Prometheus as a log aggregator here. Pushing a bunch of string values to a time series DB is not that good practice. Users may already use a log aggregator to catch Falco logs and push them to remote. So, we decided not to continue with falco-exporter since there are no useful metrics additional to what we're collecting or want to collect.

Feature

  • Do not emit falco_events
  • Gauge: dropped event count
  • Gauge: webserver requests & latency & retry & dropped
  • Gauge: audits scanned
  • Gauge: rules active
  • Gauge: events
  • ... etc.

Alternatives

-

Additional context

See falcosecurity/falco#1772 brainstorming issue to support these metrics built-in in Falco.

@Dentrax Dentrax added the kind/feature New feature or request label Feb 28, 2022
@poiana
Copy link

poiana commented May 29, 2022

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@poiana
Copy link

poiana commented Jun 28, 2022

Stale issues rot after 30d of inactivity.

Mark the issue as fresh with /remove-lifecycle rotten.

Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle rotten

@Dentrax
Copy link
Contributor Author

Dentrax commented Jun 28, 2022

/remove-lifecycle rotten
/remove-lifecycle stale

@leogr
Copy link
Member

leogr commented Aug 19, 2022

cc @jasondellaluce

@leogr
Copy link
Member

leogr commented Sep 2, 2022

/help

@poiana
Copy link

poiana commented Sep 2, 2022

@leogr:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana poiana added the help wanted Extra attention is needed label Sep 2, 2022
@poiana
Copy link

poiana commented Dec 1, 2022

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@poiana
Copy link

poiana commented Dec 31, 2022

Stale issues rot after 30d of inactivity.

Mark the issue as fresh with /remove-lifecycle rotten.

Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle rotten

@jasondellaluce
Copy link
Contributor

/remove-lifecycle rotten

@poiana
Copy link

poiana commented Apr 4, 2023

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@Dentrax
Copy link
Contributor Author

Dentrax commented Apr 6, 2023

/remove-lifecycle stale

@leogr leogr added this to the 0.9.0 milestone Apr 11, 2023
@leogr
Copy link
Member

leogr commented Apr 11, 2023

Hey @Dentrax

Any chance you would like to work on this? 👼

@Dentrax
Copy link
Contributor Author

Dentrax commented Apr 11, 2023

Hey @Dentrax

Any chance you would like to work on this? 👼

Hey!

I'm always ready to help! But my 2 cents here is to discuss and finalize the falcosecurity/falco#1772 first before taking further actions on this. I'd like to give a hand but meantime you can assign good-fist-issue label in case if someone want to get into it. 😊

@poiana
Copy link

poiana commented Jul 10, 2023

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@poiana
Copy link

poiana commented Aug 9, 2023

Stale issues rot after 30d of inactivity.

Mark the issue as fresh with /remove-lifecycle rotten.

Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle rotten

@leogr
Copy link
Member

leogr commented Aug 10, 2023

/remove-lifecycle rotten

@poiana
Copy link

poiana commented Nov 8, 2023

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@poiana
Copy link

poiana commented Dec 8, 2023

Stale issues rot after 30d of inactivity.

Mark the issue as fresh with /remove-lifecycle rotten.

Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle rotten

@leogr
Copy link
Member

leogr commented Dec 11, 2023

/remove-lifecycle stale

@poiana
Copy link

poiana commented Jan 10, 2024

Rotten issues close after 30d of inactivity.

Reopen the issue with /reopen.

Mark the issue as fresh with /remove-lifecycle rotten.

Provide feedback via https://github.com/falcosecurity/community.
/close

@poiana poiana closed this as completed Jan 10, 2024
@poiana
Copy link

poiana commented Jan 10, 2024

@poiana: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue with /reopen.

Mark the issue as fresh with /remove-lifecycle rotten.

Provide feedback via https://github.com/falcosecurity/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed kind/feature New feature or request lifecycle/rotten
Projects
None yet
Development

No branches or pull requests

4 participants