Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internationalize third party services #703

Open
wbazant opened this issue Feb 25, 2025 · 2 comments · May be fixed by #699
Open

Internationalize third party services #703

wbazant opened this issue Feb 25, 2025 · 2 comments · May be fixed by #699

Comments

@wbazant
Copy link
Collaborator

wbazant commented Feb 25, 2025

The 3rd party services should be internationalized as well as the locale:

Reported in #699 (review)

@wbazant wbazant linked a pull request Mar 2, 2025 that will close this issue
@wbazant
Copy link
Collaborator Author

wbazant commented Mar 4, 2025

Google services come with a major bummer - you can't change the language once the API has loaded. There are tricks to unload + load the script, or we can refresh the page, but I think it's useful to offer easy changes of language for e.g. comparing common names, see #705. The proposed resolution is to toast.info that the language changed, and the user can refresh page to reload map.

@wbazant
Copy link
Collaborator Author

wbazant commented Mar 4, 2025

Also, the date picker comes from the browser, you can't change language there.

AI suggested

<div lang="fr">
  <input type="date" {...props} />
</div>

but it doesn't work for me in Ubuntu/Firefox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants